You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/08 03:09:30 UTC

[GitHub] [arrow] emkornfield commented on a change in pull request #11310: ARROW-13804: [Go] Add Interval type Month, Day, Nano

emkornfield commented on a change in pull request #11310:
URL: https://github.com/apache/arrow/pull/11310#discussion_r724668690



##########
File path: go/arrow/array/interval_test.go
##########
@@ -274,3 +274,128 @@ func TestDayTimeIntervalBuilder_Empty(t *testing.T) {
 	assert.Equal(t, want, dtValues(arr))
 	arr.Release()
 }
+
+func TestMonthDayNanoArray(t *testing.T) {
+	mem := memory.NewCheckedAllocator(memory.NewGoAllocator())
+	defer mem.AssertSize(t, 0)
+
+	var (
+		want   = []arrow.MonthDayNanoInterval{{1, 1, 1000}, {2, 2, 2000}, {3, 3, 3000}, {4, 4, 4000}}

Review comment:
       test with some negative values?  maybe max and min ints for each of the fields as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org