You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Greg Rahn (Code Review)" <ge...@cloudera.org> on 2017/06/30 05:21:57 UTC
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Greg Rahn has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7342
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
[DOCS] add EPOCH to list of units supported.
Per fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java#L1593
Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7342/1
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7342/1/docs/topics/impala_datetime_functions.xml
File docs/topics/impala_datetime_functions.xml:
PS1, Line 727:
Take out trailing space on this line. (Man, this happens all the time in doc gerrits.)
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
Patch Set 2: Code-Review+2
I'll do the 'doc validation job' step and take it from here into the master branch.
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
[DOCS] add EPOCH to list of units supported.
Per fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java#L1593
Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Reviewed-on: http://gerrit.cloudera.org:8080/7342
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has uploaded a new patch set (#2).
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
[DOCS] add EPOCH to list of units supported.
Per fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java#L1593
Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
---
M docs/topics/impala_datetime_functions.xml
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7342/2
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] add EPOCH to list of units supported.
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/133/
--
To view, visit http://gerrit.cloudera.org:8080/7342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e62f295efaa9084a6da682fd04bfb067ec5e4e8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No