You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Dean Gaudet <dg...@arctic.org> on 1997/09/09 20:55:10 UTC

Re: cvs commit: apachen/src/main http_core.c


On Tue, 9 Sep 1997, Alexei Kosut wrote:

>   +	if (old_path && cmd->path[0] != '/')
>   +	    cmd->path = pstrcat(cmd->pool, old_path, cmd->path, NULL);
>   +
>   +	/* Ensure that the pathname is canonical */
>   +	cmd->path = os_canonical_filename(cmd->pool, cmd->path);
>        }
>   -    else if (old_path && cmd->path[0] != '/')
>   -	cmd->path = pstrcat(cmd->pool, old_path, cmd->path, NULL);

This looks like another spot that requires ap_is_absolute_path.

Dean


Re: cvs commit: apachen/src/main http_core.c

Posted by Alexei Kosut <ak...@organic.com>.
On Tue, 9 Sep 1997, Dean Gaudet wrote:

> On Tue, 9 Sep 1997, Alexei Kosut wrote:
> 
> >   +	if (old_path && cmd->path[0] != '/')
> >   +	    cmd->path = pstrcat(cmd->pool, old_path, cmd->path, NULL);
> >   +
> >   +	/* Ensure that the pathname is canonical */
> >   +	cmd->path = os_canonical_filename(cmd->pool, cmd->path);
> >        }
> >   -    else if (old_path && cmd->path[0] != '/')
> >   -	cmd->path = pstrcat(cmd->pool, old_path, cmd->path, NULL);
> 
> This looks like another spot that requires ap_is_absolute_path.

Ergh. Yerright, this will do odd things if you give it a name with drive
letters, won't it... Hadn't thought of that (never tried <Files> under
Windows, actually).

-- Alexei Kosut <ak...@organic.com>