[GitHub] [incubator-iceberg] mccheah commented on a change in pull request #241: Use gradle-consistent-versions to manage dependencies

[GitBox <gi...@apache.org>]

mccheah commented on a change in pull request #241: Use gradle-consistent-versions to manage dependencies
URL: https://github.com/apache/incubator-iceberg/pull/241#discussion_r298720187
 
 

 ##########
 File path: versions.props
 ##########
 @@ -0,0 +1,23 @@
+org.slf4j:slf4j-api = 1.7.5
+com.google.guava:guava = 28.0-jre
+org.apache.avro:avro = 1.8.2
+org.apache.hadoop:* = 2.7.3
+org.apache.hive:hive-standalone-metastore = 1.2.1
+org.apache.orc:orc-core = 1.5.5
+org.apache.parquet:parquet-avro = 1.10.0
+org.apache.spark:spark-hive_2.11 = 2.4.0
+org.apache.pig:pig = 0.14.0
+com.fasterxml.jackson.core:jackson-core = 2.7.9
 
 Review comment:
   Before this change, these Jackson versions used to be inconsistent. We were declaring that we wanted Jackson 2.6.7. However, spark-sql always pulled in the transitive dependency of jackson-core at version 2.7.9. I discovered this by looking at the rendered `versions.lock` file below, using `./gradlew why` to trace back the source of the dependency, and also verified using `./gradlew dependencyInsight...` before this diff.
   
   I think it's safest to fix all the Jackson components at the same version, in which case I thought we should bias towards the newer version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org