[GitHub] [tvm] cconvey commented on pull request #10891: [Hexagon] Select qaic executable based on Ubuntu version

[GitBox <gi...@apache.org>]

cconvey commented on PR #10891:
URL: https://github.com/apache/tvm/pull/10891#issuecomment-1087915495

   Thanks @kparzysz-quic !  There might be one last issue, but that's probably all:
   
   Now when `get_hexagon_sdk_property` can't obtain a valid path for `QAIC_EXE`, some (all?) callers need to check for that condition.  
   
   It looks like that's already happening in some places, for example: https://github.com/apache/tvm/blob/02b2469724103685116e5dfc95c1bfbf6bbdd071/src/runtime/hexagon/android/target/fastrpc/CMakeLists.txt#L29-L39
   
   But not in everywhere that (I think) rely on it being valid:
   - https://github.com/apache/tvm/blob/02b2469724103685116e5dfc95c1bfbf6bbdd071/cmake/modules/Hexagon.cmake#L214-L228
   - https://github.com/apache/tvm/blob/02b2469724103685116e5dfc95c1bfbf6bbdd071/apps/hexagon_launcher/cmake/android/CMakeLists.txt#L33-L37
   - https://github.com/apache/tvm/blob/02b2469724103685116e5dfc95c1bfbf6bbdd071/apps/hexagon_launcher/cmake/hexagon/CMakeLists.txt#L33-L37


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org