You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/05/20 16:07:45 UTC
[GitHub] [ignite] solveme opened a new pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
solveme opened a new pull request #9116:
URL: https://github.com/apache/ignite/pull/9116
Update versions (migrate from http repositiries):
- apache parent
- jotm
- spark-core_2.11
Fix broken configuration for jar plugin (due to versions upgrade in apache parent):
- Remove 'useDefaultManifestFile' option from ignite parent pom (due to deprecation)
- Add classifiers for artifacts in modules/extdata/uri
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] solveme commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
solveme commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651637467
##########
File path: modules/hibernate-4.2/src/test/java/org/apache/ignite/cache/hibernate/HibernateL2CacheTransactionalSelfTest.java
##########
@@ -75,7 +76,7 @@
/** {@inheritDoc} */
@Override protected void beforeTestsStarted() throws Exception {
- jotm = new Jotm(true, false);
+ jotm = new Jotm(true, false, new RmiLocalConfiguration());
Review comment:
2-arg constructor in new Jotm version will call 3-arg constructor with null value for RMI configuration, but null value for RMI configuration will lead to NPE in other Jotm methods when you run tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] solveme commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
solveme commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651653493
##########
File path: modules/extdata/uri/pom.xml
##########
@@ -64,7 +64,27 @@
<module>modules/uri-dependency</module>
</modules>
+ <properties>
Review comment:
from http://apache-ignite-developers.2346864.n4.nabble.com/Building-with-maven-3-8-1-tp52689.html
Building ignite-exdata-uri with
latest jar plugin produces errors like:
ignite-extdata-uri: You have to use a classifier to attach supplemental artifacts to the project instead of replacing them
Seems that jar plugin doesn't like when build produces multiple jars
even if they finalName's are different. Reworking build configuration
with classifiers fixed the problem.
So. Yep i reworked a little config since we will have to use classifiers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] solveme commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
solveme commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651643679
##########
File path: modules/urideploy/pom.xml
##########
@@ -111,13 +111,6 @@
<scope>test</scope>
</dependency>
- <dependency>
Review comment:
I removed only duplicated dependency definition. I mean that there is a two line-to-line copies of
<dependency>
<groupId>org.apache.ignite</groupId>
<artifactId>ignite-tools</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
one right after another. (Expand change view up for several lines)
PS. Same case for other removed dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] solveme commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
solveme commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651645100
##########
File path: parent/pom.xml
##########
@@ -293,9 +293,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <configuration>
Review comment:
Jotm has third-party dependency that has another third-party dependency that is pulled from http repo. In 2.3.1-M1 version of Jotm this third party dependency was updated so build is not failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alamar commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
alamar commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651613092
##########
File path: modules/hibernate-4.2/src/test/java/org/apache/ignite/cache/hibernate/HibernateL2CacheTransactionalSelfTest.java
##########
@@ -75,7 +76,7 @@
/** {@inheritDoc} */
@Override protected void beforeTestsStarted() throws Exception {
- jotm = new Jotm(true, false);
+ jotm = new Jotm(true, false, new RmiLocalConfiguration());
Review comment:
What does it mean and why is it needed?
##########
File path: modules/urideploy/pom.xml
##########
@@ -111,13 +111,6 @@
<scope>test</scope>
</dependency>
- <dependency>
Review comment:
Removing ignite-tools may fail the suite since ignite-tools is needed to assist their execution. Why?
##########
File path: modules/extdata/uri/pom.xml
##########
@@ -64,7 +64,27 @@
<module>modules/uri-dependency</module>
</modules>
+ <properties>
Review comment:
What is the reason for extdata-uri changes? Is it a simple refactoring?
##########
File path: parent/pom.xml
##########
@@ -293,9 +293,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
- <configuration>
Review comment:
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #9116:
URL: https://github.com/apache/ignite/pull/9116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] solveme commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
solveme commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r651643679
##########
File path: modules/urideploy/pom.xml
##########
@@ -111,13 +111,6 @@
<scope>test</scope>
</dependency>
- <dependency>
Review comment:
I removed only duplicated dependency definition. I mean that there is a two line-to-line copies of
<dependency>
<groupId>org.apache.ignite</groupId>
<artifactId>ignite-tools</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
one right after another. (Expand change view up for several lines)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] vveider commented on a change in pull request #9116: IGNITE-14753 Fix builds with maven 3.8.1+
Posted by GitBox <gi...@apache.org>.
vveider commented on a change in pull request #9116:
URL: https://github.com/apache/ignite/pull/9116#discussion_r636693426
##########
File path: modules/extdata/uri/pom.xml
##########
@@ -407,6 +430,7 @@
</execution>
</executions>
</plugin>
+
Review comment:
This empty line is excess, closing tag should go one after another without empty lines. Only similar tags and sections are separated by new line in pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org