You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/29 01:21:36 UTC
[kudu-CR] Fix bitshuffle arch-wrapper code to build on OSX
Hello Dan Burkert, David Ribeiro Alves, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5253
to review the following change.
Change subject: Fix bitshuffle arch-wrapper code to build on OSX
......................................................................
Fix bitshuffle arch-wrapper code to build on OSX
OSX doesn't have objcopy, so we don't have the avx2 symbols available.
This hard-codes the non-AVX2 symbol usage on OSX.
Change-Id: If011c166d33e8900eceb5090279d014226907e2a
---
M src/kudu/cfile/bitshuffle_arch_wrapper.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/5253/1
--
To view, visit http://gerrit.cloudera.org:8080/5253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If011c166d33e8900eceb5090279d014226907e2a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Fix bitshuffle arch-wrapper code to build on OSX
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix bitshuffle arch-wrapper code to build on OSX
......................................................................
Patch Set 1: Code-Review+2
So, avoiding upstream bitshuffle in the interest of expediency is sure saving time, eh?
--
To view, visit http://gerrit.cloudera.org:8080/5253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If011c166d33e8900eceb5090279d014226907e2a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix bitshuffle arch-wrapper code to build on OSX
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Fix bitshuffle arch-wrapper code to build on OSX
......................................................................
Fix bitshuffle arch-wrapper code to build on OSX
OSX doesn't have objcopy, so we don't have the avx2 symbols available.
This hard-codes the non-AVX2 symbol usage on OSX.
Change-Id: If011c166d33e8900eceb5090279d014226907e2a
Reviewed-on: http://gerrit.cloudera.org:8080/5253
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/bitshuffle_arch_wrapper.cc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved; Verified
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If011c166d33e8900eceb5090279d014226907e2a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix bitshuffle arch-wrapper code to build on OSX
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Fix bitshuffle arch-wrapper code to build on OSX
......................................................................
Patch Set 1: Code-Review+2 Verified+1
Tested this fix on mac osx (will still wait for jenkins to confirm this works in general)
--
To view, visit http://gerrit.cloudera.org:8080/5253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If011c166d33e8900eceb5090279d014226907e2a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No