You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "vrabaud (via GitHub)" <gi...@apache.org> on 2023/10/26 15:21:54 UTC

[PR] Check return values of WebP API functions. [guacamole-server]

vrabaud opened a new pull request, #463:
URL: https://github.com/apache/guacamole-server/pull/463

   Those will be made nodiscard at some point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Check return values of WebP API functions. [guacamole-server]

Posted by "vrabaud (via GitHub)" <gi...@apache.org>.
vrabaud commented on PR #463:
URL: https://github.com/apache/guacamole-server/pull/463#issuecomment-1782580620

   I rebased as the CI error was unrelated. Maybe it got fixed at HEAD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Check return values of WebP API functions. [guacamole-server]

Posted by "vrabaud (via GitHub)" <gi...@apache.org>.
vrabaud commented on PR #463:
URL: https://github.com/apache/guacamole-server/pull/463#issuecomment-1781619833

   It says it will take days to create an account.
   Why do I have to be the one to create a ticket? Anyway, let's wait then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Check return values of WebP API functions. [guacamole-server]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #463:
URL: https://github.com/apache/guacamole-server/pull/463#issuecomment-1784197218

   > I rebased as the CI error was unrelated. Maybe it got fixed at HEAD.
   
   Yes, there was an issue causing build failures that is now fixed.
   
   Also, I see that you got the account and opened the ticket - please update Pull Request with GUACAMOLE-XXXX: prefix, along with commit requests.
   
   Thanks!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-1875: Check return values of WebP API functions. [guacamole-server]

Posted by "vrabaud (via GitHub)" <gi...@apache.org>.
vrabaud commented on PR #463:
URL: https://github.com/apache/guacamole-server/pull/463#issuecomment-1793090889

   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GUACAMOLE-1875: Check return values of WebP API functions. [guacamole-server]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #463:
URL: https://github.com/apache/guacamole-server/pull/463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Check return values of WebP API functions. [guacamole-server]

Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #463:
URL: https://github.com/apache/guacamole-server/pull/463#issuecomment-1781408479

   Thanks @vrabaud. Please open a Jira ticket (you may need to request an account, if you don't already have one) for this and tag the Jira ticket number (GUACAMOLE-XXXX:) in both the PR and the commit messages.
   
   https://guacamole.apache.org/open-source/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org