You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "tsonglew (via GitHub)" <gi...@apache.org> on 2024/11/16 20:07:12 UTC
[PR] feat: add sw_grpc plugin [skywalking-python]
tsonglew opened a new pull request, #362:
URL: https://github.com/apache/skywalking-python/pull/362
### Add sw_grpc plugin
- [x] If adding a new plugin, add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml): grpc already exists
- [x] If adding a new plugin, add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies): grpc already exists
- [x] I have added the library to `pyproject.toml` (plugin group) by running `poetry add library --group plugins`
- [x] I have rebuilt the `Plugins.md` documentation by running `make doc-gen`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat add sw_grpc plugin [skywalking-python]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #362:
URL: https://github.com/apache/skywalking-python/pull/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat add sw_grpc plugin [skywalking-python]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #362:
URL: https://github.com/apache/skywalking-python/pull/362#discussion_r1845716323
##########
docs/en/setup/Configuration.md:
##########
@@ -97,6 +97,7 @@ export SW_AGENT_YourConfiguration=YourValue
| plugin_fastapi_collect_http_params | SW_PLUGIN_FASTAPI_COLLECT_HTTP_PARAMS | <class 'bool'> | False | This config item controls that whether the FastAPI plugin should collect the parameters of the request. |
| plugin_bottle_collect_http_params | SW_PLUGIN_BOTTLE_COLLECT_HTTP_PARAMS | <class 'bool'> | False | This config item controls that whether the Bottle plugin should collect the parameters of the request. |
| plugin_celery_parameters_length | SW_PLUGIN_CELERY_PARAMETERS_LENGTH | <class 'int'> | 512 | The maximum length of `celery` functions parameters, longer than this will be truncated, 0 turns off |
+| plugin_grpc_ignored_methods | SW_PLUGIN_GRPC_IGNORED_METHODS | <class 'str'> | | Comma-delimited list of user-defined grpc methods to ignore, like /package.Service/Method1,/package.Service/Method2 |
Review Comment:
```suggestion
| plugin_grpc_ignored_methods | SW_PLUGIN_GRPC_IGNORED_METHODS | <class 'str'> | | Comma-delimited list of user-defined grpc methods to ignore, e.g. /package.Service/Method1,/package.Service/Method2 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat add sw_grpc plugin [skywalking-python]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #362:
URL: https://github.com/apache/skywalking-python/pull/362#discussion_r1845491387
##########
docs/en/setup/Configuration.md:
##########
@@ -97,6 +97,7 @@ export SW_AGENT_YourConfiguration=YourValue
| plugin_fastapi_collect_http_params | SW_PLUGIN_FASTAPI_COLLECT_HTTP_PARAMS | <class 'bool'> | False | This config item controls that whether the FastAPI plugin should collect the parameters of the request. |
| plugin_bottle_collect_http_params | SW_PLUGIN_BOTTLE_COLLECT_HTTP_PARAMS | <class 'bool'> | False | This config item controls that whether the Bottle plugin should collect the parameters of the request. |
| plugin_celery_parameters_length | SW_PLUGIN_CELERY_PARAMETERS_LENGTH | <class 'int'> | 512 | The maximum length of `celery` functions parameters, longer than this will be truncated, 0 turns off |
+| plugin_grpc_ignore_method | SW_PLUGIN_GRPC_IGNORE_METHOD | <class 'str'> | | Comma-delimited list of grpc methods to ignore |
Review Comment:
Could you share the example of this gRPC method list?
`plugin_grpc_ignore_method` should be `plugin_grpc_ignored_methods` or `plugin_grpc_ignored_method_list`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat add sw_grpc plugin [skywalking-python]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #362:
URL: https://github.com/apache/skywalking-python/pull/362#discussion_r1845716393
##########
skywalking/config.py:
##########
@@ -297,15 +301,20 @@ def finalize_regex() -> None:
) for p0 in agent_trace_ignore_path.split(',')
) + ')$'
- global RE_IGNORE_PATH, RE_HTTP_IGNORE_METHOD
+ global RE_IGNORE_PATH, RE_HTTP_IGNORE_METHOD, RE_GRPC_IGNORE_METHOD
Review Comment:
```suggestion
global RE_IGNORE_PATH, RE_HTTP_IGNORE_METHOD, RE_GRPC_IGNORE_METHODS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat add sw_grpc plugin [skywalking-python]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #362:
URL: https://github.com/apache/skywalking-python/pull/362#issuecomment-2480851048
Please fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org