You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/07/29 19:49:48 UTC

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #805: fix DeltaStreamer writeConfig

vinothchandar commented on a change in pull request #805: fix DeltaStreamer writeConfig
URL: https://github.com/apache/incubator-hudi/pull/805#discussion_r308407329
 
 

 ##########
 File path: hoodie-utilities/src/main/java/com/uber/hoodie/utilities/deltastreamer/DeltaSync.java
 ##########
 @@ -453,14 +453,16 @@ private HoodieWriteConfig getHoodieClientConfig(SchemaProvider schemaProvider) {
     HoodieWriteConfig.Builder builder =
         HoodieWriteConfig.newBuilder()
             .withProps(props)
-            .withPath(cfg.targetBasePath)
-            .combineInput(cfg.filterDupes, true)
             .withCompactionConfig(HoodieCompactionConfig.newBuilder()
+                .fromProperties(HoodieIndexConfig.newBuilder()
 
 Review comment:
   Would n't `withProps(props)` add it in?  because even when the index config is built using `            .withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(HoodieIndex.IndexType.BLOOM).build())	` it adds to underlying props anyway
   
   ```
   public Builder withIndexConfig(HoodieIndexConfig indexConfig) {
         props.putAll(indexConfig.getProps());
         isIndexConfigSet = true;
         return this;
       }
   ```
   
   and all the config getters query `HoodieWriteConfig` props ? 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services