You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by yo...@apache.org on 2022/09/19 03:29:02 UTC

[superset] branch master updated: fix: can't show duckdb table names in the "SEE TABLE SCHEMA" dropdown list (#21495)

This is an automated email from the ASF dual-hosted git repository.

yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new fdb4702332 fix: can't show duckdb table names in the "SEE TABLE SCHEMA" dropdown list (#21495)
fdb4702332 is described below

commit fdb470233282730c87d17d1b1ab094d9980a21a2
Author: forestlzj <19...@qq.com>
AuthorDate: Mon Sep 19 11:28:49 2022 +0800

    fix: can't show duckdb table names in the "SEE TABLE SCHEMA" dropdown list (#21495)
---
 superset/db_engine_specs/duckdb.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/db_engine_specs/duckdb.py b/superset/db_engine_specs/duckdb.py
index 9f2d742212..c47282e9b7 100644
--- a/superset/db_engine_specs/duckdb.py
+++ b/superset/db_engine_specs/duckdb.py
@@ -76,5 +76,4 @@ class DuckDBEngineSpec(BaseEngineSpec):
     def get_table_names(
         cls, database: Database, inspector: Inspector, schema: Optional[str]
     ) -> List[str]:
-        """Need to disregard the schema for DuckDB"""
-        return sorted(inspector.get_table_names())
+        return sorted(inspector.get_table_names(schema))