You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/05 22:06:34 UTC
[GitHub] [flink] JingGe opened a new pull request, #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
JingGe opened a new pull request, #19365:
URL: https://github.com/apache/flink/pull/19365
## What is the purpose of the change
This PR will move ArchUnit rules defined for production code test from the test source folder to the source folder. The reason is that the rules built previously only for Flink internal usage will be required by other repos, since more submodules like connectors will be moved to external repos.
## Brief change log
- move rules to the source folder
- create a `ProductCodeArchitectureBase` holds common rules centrally.
- update dependencies
## Verifying this change
This change is a refactoring of the test code and could be verified by checking that no violation stores will be changed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19365:
URL: https://github.com/apache/flink/pull/19365#issuecomment-1089429467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7084d3171bea953c4326c023b37a3fdad7d282b9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7084d3171bea953c4326c023b37a3fdad7d282b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7084d3171bea953c4326c023b37a3fdad7d282b9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpreu commented on a diff in pull request #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
Posted by GitBox <gi...@apache.org>.
alpreu commented on code in PR #19365:
URL: https://github.com/apache/flink/pull/19365#discussion_r843612166
##########
flink-architecture-tests/flink-architecture-tests-production/pom.xml:
##########
@@ -39,35 +39,41 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-architecture-tests-base</artifactId>
+ <scope>compile</scope>
Review Comment:
Isn't `compile` already the default scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #19365:
URL: https://github.com/apache/flink/pull/19365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a diff in pull request #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
Posted by GitBox <gi...@apache.org>.
JingGe commented on code in PR #19365:
URL: https://github.com/apache/flink/pull/19365#discussion_r843640860
##########
flink-architecture-tests/flink-architecture-tests-production/pom.xml:
##########
@@ -39,35 +39,41 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-architecture-tests-base</artifactId>
+ <scope>compile</scope>
Review Comment:
no, default is `test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a diff in pull request #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
Posted by GitBox <gi...@apache.org>.
JingGe commented on code in PR #19365:
URL: https://github.com/apache/flink/pull/19365#discussion_r843640860
##########
flink-architecture-tests/flink-architecture-tests-production/pom.xml:
##########
@@ -39,35 +39,41 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-architecture-tests-base</artifactId>
+ <scope>compile</scope>
Review Comment:
yes, but the dependency mgmt is `test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a diff in pull request #19365: [FLINK-27064][test] move ArchUnit rules for production code to the source folder
Posted by GitBox <gi...@apache.org>.
JingGe commented on code in PR #19365:
URL: https://github.com/apache/flink/pull/19365#discussion_r843640860
##########
flink-architecture-tests/flink-architecture-tests-production/pom.xml:
##########
@@ -39,35 +39,41 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-architecture-tests-base</artifactId>
+ <scope>compile</scope>
Review Comment:
yes, but it is `test` defined in the dependency mgmt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org