You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "klslord (via GitHub)" <gi...@apache.org> on 2023/04/18 14:54:35 UTC
[GitHub] [incubator-kvrocks-website] klslord opened a new pull request, #91: Add logo swiper to homepage.
klslord opened a new pull request, #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91
Including animation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] PragmaTwice commented on pull request #91: Add logo swiper to homepage.
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1520217699
It looks the conflict need to be solved before the next step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber commented on pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1566142359
Wait for users with a strong recommendation intention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber commented on pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1514101403
Yes, different communities may have different practices. I'm not sure if it's a requirement from Apache for each community to remove a list of logos on the homepage. BTW, you only addressed the first point. Please take look at the other two reasons as I believe visual appeal is also important and a purely static page can be too monotonous. @tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #91: Add logo swiper to homepage.
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1514024092
Hi @klslord,
As tison mentioned, we can keep our homepage concise to let new users clearly see what's Kvrocks and its features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] PragmaTwice commented on a diff in pull request #91: Add logo swiper to homepage.
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#discussion_r1170187709
##########
src/constants.ts:
##########
@@ -1,3 +1,92 @@
// The DNS for cdn.jsdelivr.net and fastly.jsdelivr.net have been polluted by the GFW.
// For now, gcore.jsdelivr.net is still accessible, but its future availability is uncertain.
export const IMG_CDN_URL_PREFIX = 'https://gcore.jsdelivr.net/gh/apache/incubator-kvrocks-website@main/static/img/';
+
+export const userLogoFirstLine = [
Review Comment:
Could the first/second splitting be computed automatically instead of constant definition?
IMHO it is ugly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] PragmaTwice commented on a diff in pull request #91: Add logo swiper to homepage.
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#discussion_r1170190213
##########
src/constants.ts:
##########
@@ -1,3 +1,92 @@
// The DNS for cdn.jsdelivr.net and fastly.jsdelivr.net have been polluted by the GFW.
// For now, gcore.jsdelivr.net is still accessible, but its future availability is uncertain.
export const IMG_CDN_URL_PREFIX = 'https://gcore.jsdelivr.net/gh/apache/incubator-kvrocks-website@main/static/img/';
+
+export const userLogoFirstLine = [
Review Comment:
e.g. define one constant, and split it automatically.
```
const users = [...];
const firstLine, secondLine = splitUsers(users);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] klslord commented on pull request #91: Add logo swiper to homepage.
Posted by "klslord (via GitHub)" <gi...@apache.org>.
klslord commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1551539176
@PragmaTwice Hulk not find the user comment, so we temporarily remove it and will add it back when available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] klslord commented on pull request #91: Add logo swiper to homepage.
Posted by "klslord (via GitHub)" <gi...@apache.org>.
klslord commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1518562222
Added user cases, you can add specific content. @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] klslord commented on pull request #91: Add logo swiper to homepage.
Posted by "klslord (via GitHub)" <gi...@apache.org>.
klslord commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1518604766
Add self-adaption to user cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #91: Add logo swiper to homepage.
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1514104371
> The logo list is constantly scrolling, making the homepage visually more appealing.
I agree if we have users word, but not a simple logo.
> During our previous discussions in the WeChat group, I asked @git-hulk and @PragmaTwice if we still need to display the logo list on the homepage since we have it on other pages. They both suggested that we include it on the homepage as well.
We don't have a vote for it. Also, suggestions can be thrown and we reach a new consensus if so. So -1 is my vote, it doesn't mean you should follow it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on pull request #91: Add logo swiper to homepage.
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1552311061
> @PragmaTwice Hulk not find the user comment, so we temporarily remove it and will add it back when available.
Yes, thanks for your efforts. I asked some of the users, they were mainly concerned if it was good to show their words with the company information on the official website. And from my side, it makes sense and we also do not necessarily to show other company logos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber closed pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber closed pull request #91: Add logo swiper to homepage.
URL: https://github.com/apache/incubator-kvrocks-website/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #91: Add logo swiper to homepage.
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1514096922
@ColinChamber Is a boring game to find examples follow your rule. The following software (not company) doesn't show user logos:
* **Redis** https://redis.io/
* Kafka https://kafka.apache.org/
* Flink https://flink.apache.org/
* Pulsar https://pulsar.apache.org/
* ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber commented on a diff in pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber commented on code in PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#discussion_r1170693985
##########
src/constants.ts:
##########
@@ -1,3 +1,92 @@
// The DNS for cdn.jsdelivr.net and fastly.jsdelivr.net have been polluted by the GFW.
// For now, gcore.jsdelivr.net is still accessible, but its future availability is uncertain.
export const IMG_CDN_URL_PREFIX = 'https://gcore.jsdelivr.net/gh/apache/incubator-kvrocks-website@main/static/img/';
+
+export const userLogoFirstLine = [
Review Comment:
You are right! Here are some issues. The initial consideration was that we wanted to put some well-known companies in the first row. In fact, obtaining the segmentation according to the order of users can also achieve this effect (provided that the maintainer arranges the users in advance according to some rules).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber commented on pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1518576683
I suppose that we still add the logo list at this stage. After kvrocks graduates from the Apache Incubator, I will remember to delete the logo list (return to simplicity).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] klslord commented on pull request #91: Add logo swiper to homepage.
Posted by "klslord (via GitHub)" <gi...@apache.org>.
klslord commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1525713469
Update. @PragmaTwice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] klslord commented on a diff in pull request #91: Add logo swiper to homepage.
Posted by "klslord (via GitHub)" <gi...@apache.org>.
klslord commented on code in PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#discussion_r1174342515
##########
src/constants.ts:
##########
@@ -1,3 +1,92 @@
// The DNS for cdn.jsdelivr.net and fastly.jsdelivr.net have been polluted by the GFW.
// For now, gcore.jsdelivr.net is still accessible, but its future availability is uncertain.
export const IMG_CDN_URL_PREFIX = 'https://gcore.jsdelivr.net/gh/apache/incubator-kvrocks-website@main/static/img/';
+
+export const userLogoFirstLine = [
Review Comment:
solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on pull request #91: Add logo swiper to homepage.
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1514110373
> purely static page can be too monotonous
As a homepage for technical software, the landing page can consist of:
* Appealing hero banner
* Key features
* Showcases
* Links to other content
The landing page is to help users understand what this software is and if the software generally fits their usage. Logos help little for these purposes. Leading users with endorsement sentences _may_ help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber commented on pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1513321633
https://github.com/apache/incubator-kvrocks/issues/1257 related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] ColinChamber commented on pull request #91: Add logo swiper to homepage.
Posted by "ColinChamber (via GitHub)" <gi...@apache.org>.
ColinChamber commented on PR #91:
URL: https://github.com/apache/incubator-kvrocks-website/pull/91#issuecomment-1514096134
Hi tison @tisonkun ,
Indeed, it would be good to include user cases. However, the logo list should also be retained. Here are my thoughts:
1. Many open source projects or organizations display a logo list on their homepage, such as [Nebula](
https://www.nebula-graph.com.cn/) and [CNCF](https://www.cncf.io/)
2. The logo list is constantly scrolling, making the homepage visually more appealing.
3. During our previous discussions in the WeChat group, I asked @git-hulk and @PragmaTwice if we still need to display the logo list on the homepage since we have it on other pages. They both suggested that we include it on the homepage as well.
Finally, we will add user cases in the future, similar to the layout on Nebula's homepage. Like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org