You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/08 17:43:27 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #5758: Insert correct template size when live migrating VM with volumes
GutoVeronezi opened a new pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758
### Description
When a volume is copied to another storage pool, if the template does not exist in the destination storage pool yet, it should be copied. The API `migrateVirtualMachineWithVolume` already does it; however, when migrating the volume with `migrateVolume` (VM stopped), the template is not copied, which causes inconsistencies in the database and primary storage systems. The not existence of the template in the storage pool causes an NPE when using the API `migrateVirtualMachineWithVolume`.
This PR intends to avoid this NPE.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
I tested it in a test lab.
1. I created a VM;
2. I stopped the VM;
3. I created a new primary storage;
4. With API `migrateVolume` I migrated the volume to the new primary storage;
5. Before this changes, when I tried to migrate the volume to another primary storage that does not have the template yet, it threw a NPE.
6. After this changes, when I tried to migrate the volume to another primary storage that does not have the template yet, the migration could be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993687474
> @sureshanaparti done. As soon as it get merged, I'll create another PR to main branch.
thanks @GutoVeronezi, no need of another PR to main branch, we can forward merge this changes to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-995778958
> @sureshanaparti done. As soon as it get merged, I'll create another PR to main branch.
this is not needed @GutoVeronezi . part of the release managers task on dot releases is to forward merge any commits to newer release branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993517910
@sureshanaparti done. As soon as it get merged, I'll create another PR to main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992228573
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993684778
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992194663
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-994277379
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-994276948
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-995888876
Merging based on approvals and test results (test failure above is unrelated to this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992730696
<b>Trillian test result (tid-2646)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32062 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5758-t2646-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992233206
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992232278
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993685422
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993197227
> @GutoVeronezi Is this PR good to go in 4.16.1? If so, rebase it with '4.16' branch.
Hi @GutoVeronezi Can you confirm if this is good for 4.16.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993517910
@sureshanaparti done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992229609
@GutoVeronezi Is this PR good to go in 4.16.1? If so, rebase it with '4.16' branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-994814085
<b>Trillian test result (tid-2659)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5758-t2659-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_disable_oobm_ha_state_ineligible | `Error` | 1543.50 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-992194509
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5758: Fix NPE on migrateVirtualMachineWithVolume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5758:
URL: https://github.com/apache/cloudstack/pull/5758#issuecomment-993750010
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org