You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/04 02:31:17 UTC
[GitHub] [hadoop] aajisaka commented on a change in pull request #1397:
MAPREDUCE-7237. Supports config the shuffle's path cache related parameters
aajisaka commented on a change in pull request #1397: MAPREDUCE-7237. Supports config the shuffle's path cache related parameters
URL: https://github.com/apache/hadoop/pull/1397#discussion_r387416495
##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
##########
@@ -1266,6 +1266,29 @@
</description>
</property>
+<property>
+ <name>mapreduce.shuffle.pathcache.max-weight</name>
+ <value>10 * 1024 * 1024</value>
Review comment:
Thanks @jiwq for the reply and the update.
One comment: the style cannot be parsed by org.apache.hadoop.conf.Configuration.
```suggestion
<value>10485760</value>
```
+1 if that is addressed.
Sorry I forgot to review for a long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org