You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Joe Orton <jo...@redhat.com> on 2006/09/29 14:33:25 UTC
Re: svn commit: r451006 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c
On Thu, Sep 28, 2006 at 08:15:44PM -0000, rpluem@apache.org wrote:
> --- httpd/httpd/trunk/modules/generators/mod_cgi.c (original)
> +++ httpd/httpd/trunk/modules/generators/mod_cgi.c Thu Sep 28 13:15:42 2006
> @@ -837,6 +837,11 @@
> APR_BLOCK_READ, HUGE_STRING_LEN);
>
> if (rv != APR_SUCCESS) {
> + if (rv == APR_TIMEUP) {
These should use APR_STATUS_IS_TIMEUP() rather than checking against
APR_TIMEUP directly.
joe
Re: svn commit: r451006 - in /httpd/httpd/trunk/modules/generators:
mod_cgi.c mod_cgid.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 09/29/2006 03:49 PM, Garrett Rooney wrote:
> On 9/29/06, Joe Orton <jo...@redhat.com> wrote:
>
>> On Thu, Sep 28, 2006 at 08:15:44PM -0000, rpluem@apache.org wrote:
>> > --- httpd/httpd/trunk/modules/generators/mod_cgi.c (original)
>> > +++ httpd/httpd/trunk/modules/generators/mod_cgi.c Thu Sep 28
>> 13:15:42 2006
>> > @@ -837,6 +837,11 @@
>> > APR_BLOCK_READ, HUGE_STRING_LEN);
>> >
>> > if (rv != APR_SUCCESS) {
>> > + if (rv == APR_TIMEUP) {
>>
>> These should use APR_STATUS_IS_TIMEUP() rather than checking against
>> APR_TIMEUP directly.
>
>
> Fixed in 451289.
You are too fast for me :-). Just wanted to fix that.
Regards
Rüdiger
Re: svn commit: r451006 - in /httpd/httpd/trunk/modules/generators: mod_cgi.c mod_cgid.c
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 9/29/06, Joe Orton <jo...@redhat.com> wrote:
> On Thu, Sep 28, 2006 at 08:15:44PM -0000, rpluem@apache.org wrote:
> > --- httpd/httpd/trunk/modules/generators/mod_cgi.c (original)
> > +++ httpd/httpd/trunk/modules/generators/mod_cgi.c Thu Sep 28 13:15:42 2006
> > @@ -837,6 +837,11 @@
> > APR_BLOCK_READ, HUGE_STRING_LEN);
> >
> > if (rv != APR_SUCCESS) {
> > + if (rv == APR_TIMEUP) {
>
> These should use APR_STATUS_IS_TIMEUP() rather than checking against
> APR_TIMEUP directly.
Fixed in 451289.
-garrett