You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by er...@apache.org on 2005/11/24 14:55:22 UTC

svn commit: r348733 - in /directory/sandbox/ersiner/apacheds-with-storedprocs: core-unit/src/test/java/org/apache/ldap/server/storedprocs/ core/src/main/java/org/apache/ldap/server/storedprocs/

Author: ersiner
Date: Thu Nov 24 05:55:07 2005
New Revision: 348733

URL: http://svn.apache.org/viewcvs?rev=348733&view=rev
Log:
Minor cleanup.


Modified:
    directory/sandbox/ersiner/apacheds-with-storedprocs/core-unit/src/test/java/org/apache/ldap/server/storedprocs/JavaStoredProcTest.java
    directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/JavaStoredProcedure.java
    directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/StoredProcedure.java

Modified: directory/sandbox/ersiner/apacheds-with-storedprocs/core-unit/src/test/java/org/apache/ldap/server/storedprocs/JavaStoredProcTest.java
URL: http://svn.apache.org/viewcvs/directory/sandbox/ersiner/apacheds-with-storedprocs/core-unit/src/test/java/org/apache/ldap/server/storedprocs/JavaStoredProcTest.java?rev=348733&r1=348732&r2=348733&view=diff
==============================================================================
--- directory/sandbox/ersiner/apacheds-with-storedprocs/core-unit/src/test/java/org/apache/ldap/server/storedprocs/JavaStoredProcTest.java (original)
+++ directory/sandbox/ersiner/apacheds-with-storedprocs/core-unit/src/test/java/org/apache/ldap/server/storedprocs/JavaStoredProcTest.java Thu Nov 24 05:55:07 2005
@@ -55,23 +55,15 @@
         attributes.put( "byteCode", HELLOWORLD_CLASS_BYTES );
         sysRoot.createSubcontext( "fqcn=HelloWorld", attributes );
         assertNotNull( sysRoot.lookup( "fqcn=HelloWorld" ) );
-
         
+        // create the sp instance
         StoredProcedure sp = new JavaStoredProcedure(
                 ( ServerLdapContext ) ( sysRoot.lookup( "" ) ), 
                 "HelloWorld.main",
                 new Class[] { String[].class }
                 );
         
+        // invoke the sp
         sp.call( new Object[] { new String[] {} } );
-        
-//        // load the class
-//        LdapClassLoader loader = new LdapClassLoader( ( ServerLdapContext ) ( sysRoot.lookup( "" ) ) );
-//        Class clazz = loader.loadClass( "HelloWorld" );
-//        assertEquals( clazz.getName(), "HelloWorld" );
-//               
-//        // call a static method over loaded class via reflection
-//        Method m = clazz.getMethod("main", new Class[] { (new String[] {}).getClass() });
-//        m.invoke( null, new Object[] { new String[] {} } );
     }
 }

Modified: directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/JavaStoredProcedure.java
URL: http://svn.apache.org/viewcvs/directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/JavaStoredProcedure.java?rev=348733&r1=348732&r2=348733&view=diff
==============================================================================
--- directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/JavaStoredProcedure.java (original)
+++ directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/JavaStoredProcedure.java Thu Nov 24 05:55:07 2005
@@ -24,6 +24,7 @@
 
 import org.apache.ldap.server.jndi.ServerLdapContext;
 
+
 /**
  * Default implementation of StoredProcedure Interface.
  * 
@@ -47,7 +48,7 @@
         this.fQSPName = fullyQualifiedSPName;
         this.parameterTypes = parameterTypes;
         
-        methodClass = new LdapClassLoader( this.ctx ).loadClass( getFqClassNameFromFqSPName( this.fQSPName ) );
+        this.methodClass = new LdapClassLoader( this.ctx ).loadClass( getFqClassNameFromFqSPName( this.fQSPName ) );
         
         this.method = methodClass.getMethod( getSPNameFromFqSPName( this.fQSPName ), this.parameterTypes );
     }
@@ -80,6 +81,7 @@
             // TODO Auto-generated catch block
             e.printStackTrace();
         }
+        
         return returnValue;
     }
 }

Modified: directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/StoredProcedure.java
URL: http://svn.apache.org/viewcvs/directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/StoredProcedure.java?rev=348733&r1=348732&r2=348733&view=diff
==============================================================================
--- directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/StoredProcedure.java (original)
+++ directory/sandbox/ersiner/apacheds-with-storedprocs/core/src/main/java/org/apache/ldap/server/storedprocs/StoredProcedure.java Thu Nov 24 05:55:07 2005
@@ -18,7 +18,9 @@
 
 package org.apache.ldap.server.storedprocs;
 
+
 import java.lang.reflect.InvocationTargetException;
+
 
 public interface StoredProcedure
 {