[GitHub] [druid] josephglanville commented on a change in pull request #10232: Fix Avro support in Web Console

[GitBox <gi...@apache.org>]

josephglanville commented on a change in pull request #10232:
URL: https://github.com/apache/druid/pull/10232#discussion_r469704324



##########
File path: extensions-core/avro-extensions/src/test/java/org/apache/druid/data/input/avro/AvroFlattenerMakerTest.java
##########
@@ -78,7 +78,8 @@ public void getRootField()
         flattener.getRootField(record, "someNull")
     );
     Assert.assertEquals(
-        record.getSomeFixed(),
+        // Casted to an array by transformValue
+        record.getSomeFixed().bytes(),

Review comment:
       Yes so `fixed` and `bytes` are encoded equivalently in Avro, `fixed` just has an enforced size. There is a `binaryAsString` option for decoding these as strings if need be. It would be nice to support that as a per-field transformation though rather than applying to all binary types as you may only want some to be interpreted as strings and others to be returned verbatim.
   
   If docs were to be added I would probably put them on the `druid-avro-extensions` page and link to them from the various places Avro parsing it used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org