You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Devaraj K (Created) (JIRA)" <ji...@apache.org> on 2011/12/14 06:48:30 UTC
[jira] [Created] (MAPREDUCE-3556) Resource Leaks in key flows
Resource Leaks in key flows
---------------------------
Key: MAPREDUCE-3556
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3556
Project: Hadoop Map/Reduce
Issue Type: Bug
Affects Versions: 0.23.0
Reporter: Devaraj K
Assignee: Devaraj K
{code:title=MapTask.java|borderStyle=solid}
{code}
{code:xml}
if (combinerRunner == null || numSpills < minSpillsForCombine) {
Merger.writeFile(kvIter, writer, reporter, job);
} else {
combineCollector.setWriter(writer);
combinerRunner.combine(kvIter, combineCollector);
}
//close
writer.close();
{code}
{code:title=InputSampler.java|borderStyle=solid}
{code}
{code:xml}
for(int i = 1; i < numPartitions; ++i) {
int k = Math.round(stepSize * i);
while (last >= k && comparator.compare(samples[last], samples[k]) == 0) {
++k;
}
writer.append(samples[k], nullValue);
last = k;
}
writer.close();{code}
The key flows have potential resource leaks.
{code:title=JobSplitWriter.java|borderStyle=solid}
{code}
{code:xml}
SplitMetaInfo[] info = writeNewSplits(conf, splits, out);
out.close();
SplitMetaInfo[] info = writeOldSplits(splits, out);
out.close();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3556) Resource Leaks in key flows
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170319#comment-13170319 ]
Hadoop QA commented on MAPREDUCE-3556:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507537/MAPREDUCE-3556.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup
org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1461//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1461//console
This message is automatically generated.
> Resource Leaks in key flows
> ---------------------------
>
> Key: MAPREDUCE-3556
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3556
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-3556.patch
>
>
> {code:title=MapTask.java|borderStyle=solid}
> {code}
> {code:xml}
> if (combinerRunner == null || numSpills < minSpillsForCombine) {
> Merger.writeFile(kvIter, writer, reporter, job);
> } else {
> combineCollector.setWriter(writer);
> combinerRunner.combine(kvIter, combineCollector);
> }
> //close
> writer.close();
> {code}
> {code:title=InputSampler.java|borderStyle=solid}
> {code}
> {code:xml}
> for(int i = 1; i < numPartitions; ++i) {
> int k = Math.round(stepSize * i);
> while (last >= k && comparator.compare(samples[last], samples[k]) == 0) {
> ++k;
> }
> writer.append(samples[k], nullValue);
> last = k;
> }
> writer.close();{code}
> The key flows have potential resource leaks.
> {code:title=JobSplitWriter.java|borderStyle=solid}
> {code}
> {code:xml}
> SplitMetaInfo[] info = writeNewSplits(conf, splits, out);
> out.close();
> SplitMetaInfo[] info = writeOldSplits(splits, out);
> out.close();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3556) Resource Leaks in key flows
Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-3556:
---------------------------------
Attachment: MAPREDUCE-3556.patch
> Resource Leaks in key flows
> ---------------------------
>
> Key: MAPREDUCE-3556
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3556
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-3556.patch
>
>
> {code:title=MapTask.java|borderStyle=solid}
> {code}
> {code:xml}
> if (combinerRunner == null || numSpills < minSpillsForCombine) {
> Merger.writeFile(kvIter, writer, reporter, job);
> } else {
> combineCollector.setWriter(writer);
> combinerRunner.combine(kvIter, combineCollector);
> }
> //close
> writer.close();
> {code}
> {code:title=InputSampler.java|borderStyle=solid}
> {code}
> {code:xml}
> for(int i = 1; i < numPartitions; ++i) {
> int k = Math.round(stepSize * i);
> while (last >= k && comparator.compare(samples[last], samples[k]) == 0) {
> ++k;
> }
> writer.append(samples[k], nullValue);
> last = k;
> }
> writer.close();{code}
> The key flows have potential resource leaks.
> {code:title=JobSplitWriter.java|borderStyle=solid}
> {code}
> {code:xml}
> SplitMetaInfo[] info = writeNewSplits(conf, splits, out);
> out.close();
> SplitMetaInfo[] info = writeOldSplits(splits, out);
> out.close();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3556) Resource Leaks in key flows
Posted by "Devaraj K (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-3556:
---------------------------------
Status: Patch Available (was: Open)
Attaching the patch with the fix.
> Resource Leaks in key flows
> ---------------------------
>
> Key: MAPREDUCE-3556
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3556
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-3556.patch
>
>
> {code:title=MapTask.java|borderStyle=solid}
> {code}
> {code:xml}
> if (combinerRunner == null || numSpills < minSpillsForCombine) {
> Merger.writeFile(kvIter, writer, reporter, job);
> } else {
> combineCollector.setWriter(writer);
> combinerRunner.combine(kvIter, combineCollector);
> }
> //close
> writer.close();
> {code}
> {code:title=InputSampler.java|borderStyle=solid}
> {code}
> {code:xml}
> for(int i = 1; i < numPartitions; ++i) {
> int k = Math.round(stepSize * i);
> while (last >= k && comparator.compare(samples[last], samples[k]) == 0) {
> ++k;
> }
> writer.append(samples[k], nullValue);
> last = k;
> }
> writer.close();{code}
> The key flows have potential resource leaks.
> {code:title=JobSplitWriter.java|borderStyle=solid}
> {code}
> {code:xml}
> SplitMetaInfo[] info = writeNewSplits(conf, splits, out);
> out.close();
> SplitMetaInfo[] info = writeOldSplits(splits, out);
> out.close();
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira