You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/09/02 19:34:35 UTC

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/23366

to review the following change.


Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Reviewed-on: http://gerrit.cloudera.org:8080/23295
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 64 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/23366/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 05:07:25 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1739/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:35:04 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1748/


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 23:53:37 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1740/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:36:57 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1745/


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 22:35:51 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 06:42:46 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 2: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1740/


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:36:45 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23366

to look at the new patch set (#2).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Reviewed-on: http://gerrit.cloudera.org:8080/23295
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 64 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/23366/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1739/


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 19:34:45 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23366

to look at the new patch set (#3).

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Reviewed-on: http://gerrit.cloudera.org:8080/23295
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 65 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/23366/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 3:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/1745/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 23:53:32 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................

Fix compilation if using OpenSSL < 1.1.1

This change adds a version guard around the call to
SSL_CTX_set_ciphersuites() so it only compiles when
building with OpenSSL versions that support it. This
addresses a build failure caused by commit f6fbcde on
systems using OpenSSL 1.0.x.

The --webserver_tls_min_protocol flag's validator is
also updated to check for the set TLS version against
the available version.

The build has been tested successfully in CentOS 7.9
machine.

This is a followup to f6fbcde.

Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Reviewed-on: http://gerrit.cloudera.org:8080/23295
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-on: http://gerrit.cloudera.org:8080/23366
---
M src/kudu/server/webserver_options.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/squeasel-tls-openssl10x.patch
3 files changed, 65 insertions(+), 7 deletions(-)

Approvals:
  Abhishek Chennaka: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1748/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Sep 2025 01:51:08 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) Fix compilation if using OpenSSL < 1.1.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23366 )

Change subject: Fix compilation if using OpenSSL < 1.1.1
......................................................................


Patch Set 2:

Something is wrong: https://jenkins.kudu.apache.org/job/pre_commit/1740/pipeline-graph/


-- 
To view, visit http://gerrit.cloudera.org:8080/23366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7410a1f08e700efd8a917be8c59d54a497023cef
Gerrit-Change-Number: 23366
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 02 Sep 2025 20:36:18 +0000
Gerrit-HasComments: No