[GitHub] [superset] hughhhh commented on a diff in pull request #24471: fix(oracle): denormalize column names where applicable

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #24471:
URL: https://github.com/apache/superset/pull/24471#discussion_r1237845786


##########
superset/connectors/sqla/utils.py:
##########
@@ -75,6 +76,8 @@ def get_physical_table_metadata(
                 )
                 col.update(
                     {
+                        "name": name,
+                        "column_name": name,

Review Comment:
   @villebro we were worried about backwards compatibility, since some clients/users are only using the API. Looking to deprecate name in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org