[GitHub] [calcite] julianhyde commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary

[GitBox <gi...@apache.org>]

julianhyde commented on issue #1033: [CALCITE-2820] Avoid reducing certain aggregate functions when it is not necessary
URL: https://github.com/apache/calcite/pull/1033#issuecomment-471717544
 
 
   @zabetak Thanks for the review. I agree with everything you have said, except adding '@throws NullPointerException' to the javadoc. These days when I write APIs I am assuming that non-primitive arguments are non-null unless the API states otherwise. So '@throws NPE' in the javadoc is redundant. If fields are declared final, and assigned a value that is wrapped in `Objects.requireNotNull`, everyone including my IDE can deduce the rest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services