You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2009/10/09 17:40:46 UTC
Re: svn commit: r39868 - trunk/subversion/libsvn_subr
On Thu, Oct 8, 2009 at 08:00, Julian Foad <ju...@btopenworld.com> wrote:
> Author: julianfoad
> Date: Thu Oct 8 05:00:11 2009
> New Revision: 39868
>
> Log:
> Remove an instance of declaration-after-code.
>
> * subversion/libsvn_subr/auth.c
> (svn_auth_get_platform_specific_provider): Initialiase a local var in its
> definition.
>
> Modified:
> trunk/subversion/libsvn_subr/auth.c
>
> Modified: trunk/subversion/libsvn_subr/auth.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/auth.c?pathrev=39868&r1=39867&r2=39868
> ==============================================================================
> --- trunk/subversion/libsvn_subr/auth.c Thu Oct 8 03:18:40 2009 (r39867)
> +++ trunk/subversion/libsvn_subr/auth.c Thu Oct 8 05:00:11 2009 (r39868)
> @@ -415,8 +415,8 @@ svn_auth_get_platform_specific_provider
> dso,
> version_function_name) == 0)
> {
> - svn_version_func_t version_function;
> - version_function = (svn_version_func_t) version_function_symbol;
> + svn_version_func_t version_function
> + = (svn_version_func_t) version_function_symbol;
Is that cast really needed? If so, then that would be bad...
mismatched prototypes.. ugh.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405611
Re: svn commit: r39868 - trunk/subversion/libsvn_subr
Posted by Julian Foad <ju...@btopenworld.com>.
Greg Stein wrote:
> > - svn_version_func_t version_function;
> > - version_function = (svn_version_func_t) version_function_symbol;
> > + svn_version_func_t version_function
> > + = (svn_version_func_t) version_function_symbol;
>
> Is that cast really needed? If so, then that would be bad...
> mismatched prototypes.. ugh.
They (there were two more in that file) were just redundant explicit
casts from (void *). Gone in r39915.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405735