[GitHub] [pinot] jackjlli commented on a diff in pull request #8812: Fix segment generation error handling

[GitBox <gi...@apache.org>]

jackjlli commented on code in PR #8812:
URL: https://github.com/apache/pinot/pull/8812#discussion_r888219731


##########
pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-spark/pom.xml:
##########
@@ -33,9 +33,9 @@
   <url>https://pinot.apache.org/</url>
   <properties>
     <pinot.root>${basedir}/../../../..</pinot.root>
-    <spark.version>2.4.0</spark.version>
-    <scala.binary.version>2.11</scala.binary.version>
-    <scala.version>2.11.11</scala.version>
+    <spark.version>2.4.7</spark.version>
+    <scala.binary.version>2.12</scala.binary.version>

Review Comment:
   Do we know why we need to bump up the Scala version in this module? This module is in v0_deprecated module and it shouldn't affect the one in standalone module (correct me if I'm wrong). And directly bumping up Scala version may cause some runtime issue on some of the existing platforms which are running with Scala 2.11.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org