You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/10 23:43:17 UTC
[GitHub] [beam] nehsyc commented on pull request #13069: [BEAM-10475] Add a well-known coder for ShardedKey in Java SDK
nehsyc commented on pull request #13069:
URL: https://github.com/apache/beam/pull/13069#issuecomment-706626478
R: @robertwb @lukecwik
PTAL and see if the changes make sense and if there is anything I am missing.
I am not sure what to do with the .yaml files... The locally modified file `sdks/python/apache_beam/portability/api/standard_coders.yaml` caused some python tests fail somehow. I wasn't intended to include that file in this PR since it is for Java SDk but I ended up reverting the changes and added that file here. Any guidance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org