[GitHub] [phoenix-connectors] stoty commented on a diff in pull request #101: PHOENIX-6937 Remove the connectors for Phoenix 4.x

["stoty (via GitHub)" <gi...@apache.org>]

stoty commented on code in PR #101:
URL: https://github.com/apache/phoenix-connectors/pull/101#discussion_r1193302513


##########
pom.xml:
##########
@@ -42,54 +42,50 @@
   </scm>
 
   <modules>
-      <module>phoenix-connectors-phoenix4-compat</module>
-      <module>phoenix-connectors-phoenix5-compat</module>
       <!-- Changing the module order here may cause maven to get stuck in an infinite loop -->
-      <module>phoenix-hive-base</module>
-      <module>phoenix-flume-base</module>
-      <module>phoenix-kafka-base</module>
-      <module>phoenix-spark-base</module>
+      <module>phoenix5-hive</module>
+      <module>phoenix5-hive-shaded</module>
+      <module>phoenix5-flume</module>
+      <module>phoenix5-kafka</module>
+      <module>phoenix5-spark</module>
+      <module>phoenix5-spark-shaded</module>
       <module>phoenix5-spark3</module>
       <module>phoenix5-spark3-it</module>
       <module>phoenix5-spark3-shaded</module>
-      <module>phoenix4-connectors-assembly</module>
       <module>phoenix5-connectors-assembly</module>
   </modules>
 
   <properties>
     <!-- Phoenix Version -->
-    <phoenix-four.version>4.16.0</phoenix-four.version>
-    <phoenix-five.version>5.1.2</phoenix-five.version>
+    <phoenix.version>5.1.2</phoenix.version>
     <phoenix.thirdparty.version>2.0.0</phoenix.thirdparty.version>
     <!-- Hadoop Versions -->
-    <hbase-one.version>1.4.10</hbase-one.version>
-    <hbase-one.compat.version>1.4.0</hbase-one.compat.version>
-    <hbase-one.zookeeper.version>3.4.12</hbase-one.zookeeper.version>
+<!--    <hbase-one.version>1.4.10</hbase-one.version>-->

Review Comment:
   No need to comment out, just remove these



##########
phoenix5-spark3/src/main/java/org/apache/phoenix/spark/sql/connector/reader/PhoenixDataSourceReadOptions.java:
##########
@@ -34,7 +34,7 @@ class PhoenixDataSourceReadOptions implements Serializable {
     PhoenixDataSourceReadOptions(String zkUrl, String scn, String tenantId,
                                  String selectStatement, Properties overriddenProps,
         byte[] pTableCacheBytes) {
-        if(overriddenProps == null){
+        if (overriddenProps == null) {

Review Comment:
   Can you undo whitespace-only changes for this patch ?
   It would make it easier the find the real changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org