You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/01 02:57:11 UTC

[GitHub] [kafka] wcarlson5 commented on a change in pull request #11813: KAFKA-12648: fix #add/removeNamedTopology blocking behavior when app is in CREATED

wcarlson5 commented on a change in pull request #11813:
URL: https://github.com/apache/kafka/pull/11813#discussion_r816411304



##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/NamedTopologyTest.java
##########
@@ -149,7 +149,7 @@ public void shouldThrowTopologyExceptionWhenMultipleNamedTopologiesCreateStreamF
     }
 
     @Test
-    public void shouldThrowTopologyExceptionWhenAddingNamedTopologyReadingFromSameInputTopic() {
+    public void shouldThrowTopologyExceptionWhenAddingNamedTopologyReadingFromSameInputTopicAfterStart() {

Review comment:
       Sorry that was a bit cryptic. After start as a suffix doesn't really make sense to me as we never call start. Maybe "before start"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org