You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lenni Kuff <ls...@cloudera.com> on 2015/02/07 02:43:48 UTC

Re: Review Request 29240: SENTRY-480:Create import tool that will load policy file about Solr into the DB store

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29240/#review71539
-----------------------------------------------------------


Why not update the existing config tool to provide a solr option rather than creating a second tool that does the same thing?

- Lenni Kuff


On Jan. 29, 2015, 7:08 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29240/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 7:08 a.m.)
> 
> 
> Review request for sentry, Xiaomeng Huang, Colin Ma, Dapeng Sun, Gregory Chanan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Currently Solr does support index-level security via sentry with file as backend privilege store. Using file as the backend store is simple, but there has some disadvantages as followings:
> 
> Can't satisfied with the needs of dynamically add, delete and update permissions
> Can't be centrally managed and difficult to maintain
> According to the above disadvantages, The Solr Sentry plug-in integration with DB store is demanded. The Hive Sentry plug-in has already integration with DB store, but the Hive authorization model is different from the Solr authorization model.So this new feature depends on the generic authorization model(SENTRY-398)
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-solr/pom.xml 2dfc933 
>   sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java faf862f 
>   sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java PRE-CREATION 
>   sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrSentryConfigTool.java PRE-CREATION 
>   sentry-binding/sentry-binding-solr/src/test/resources/solr_config_import_tool.ini PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shen guoquan
> 
>


Re: Review Request 29240: SENTRY-480:Create import tool that will load policy file about Solr into the DB store

Posted by shen guoquan <gu...@intel.com>.

> On 二月 7, 2015, 1:43 a.m., Lenni Kuff wrote:
> > Why not update the existing config tool to provide a solr option rather than creating a second tool that does the same thing?

Hi Lenni. Thanks for your advice. I have thought your idea before. But I found it is not suitable for Solr component using the configTool in the hive binding package. Firstly If using the config tool in the hive binding, it must add search model dependency in the hive binding package. I thought that is improper for hive binding package. Secondly the import tool for solr uses the generic model, and it is different with the hive import tool. Thanks


- shen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29240/#review71539
-----------------------------------------------------------


On 一月 29, 2015, 7:08 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29240/
> -----------------------------------------------------------
> 
> (Updated 一月 29, 2015, 7:08 a.m.)
> 
> 
> Review request for sentry, Xiaomeng Huang, Colin Ma, Dapeng Sun, Gregory Chanan, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Currently Solr does support index-level security via sentry with file as backend privilege store. Using file as the backend store is simple, but there has some disadvantages as followings:
> 
> Can't satisfied with the needs of dynamically add, delete and update permissions
> Can't be centrally managed and difficult to maintain
> According to the above disadvantages, The Solr Sentry plug-in integration with DB store is demanded. The Hive Sentry plug-in has already integration with DB store, but the Hive authorization model is different from the Solr authorization model.So this new feature depends on the generic authorization model(SENTRY-398)
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-solr/pom.xml 2dfc933 
>   sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java faf862f 
>   sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java PRE-CREATION 
>   sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrSentryConfigTool.java PRE-CREATION 
>   sentry-binding/sentry-binding-solr/src/test/resources/solr_config_import_tool.ini PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29240/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shen guoquan
> 
>