You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mhansonp (GitHub)" <gi...@apache.org> on 2018/10/11 22:23:33 UTC

[GitHub] [geode] mhansonp opened pull request #2597: Geode 5728

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on issue #2597: Geode 5728

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
@WireBaron @galen-pivotal @upthewaterspout 

[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on issue #2597: Geode 5728

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
@WireBaron @galen-pivotal @upthewaterspout 

[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2597: Geode 5728

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
You'll want to fix the PR message to be "GEODE-XXXX: Some description of work"

[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp commented on pull request #2597: Geode 5728

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
Important part of the fix here...


[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on issue #2597: Geode 5728

Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
You'll want to fix the commit message to be "GEODE-XXXX: Some description of work"

[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mhansonp closed pull request #2597: Geode 5728

Posted by "mhansonp (GitHub)" <gi...@apache.org>.
[ pull request closed by mhansonp ]

[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org