You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 17:58:54 UTC

[GitHub] [beam] udim commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state

udim commented on a change in pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state
URL: https://github.com/apache/beam/pull/11060#discussion_r392386221
 
 

 ##########
 File path: sdks/python/apache_beam/runners/sdf_utils.py
 ##########
 @@ -244,3 +251,63 @@ def get_estimator_state(self):
         return None
 
     return _NoOpWatermarkEstimator()
+
+
+class DeduplictaionWithinDuration(ptransform.PTransform):
 
 Review comment:
   Unlike Java, we typically don't put transforms in their own module in Python. I would recommend putting it under an existing file such as transforms/util.py.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services