You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/16 11:24:53 UTC

[GitHub] [incubator-nuttx-apps] davids5 commented on a diff in pull request #1282: apps: Fix bug by calling getrandom

davids5 commented on code in PR #1282:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1282#discussion_r946622835


##########
fsutils/mkgpt/mkgpt.c:
##########
@@ -128,12 +129,12 @@ static const uint8_t g_partition_type_swap[16] =
 
 static void get_uuid(FAR uint8_t *uuid)
 {
-  int fd;
-  fd = open("/dev/urandom", O_RDONLY);
-  if (fd > 0)
+  /* call getrandom to read  /dev/urandom */

Review Comment:
   Is the comment correct any longer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org