You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2015/11/06 12:04:46 UTC
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 11:04 a.m.)
Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
Changes
-------
Moved `SizeAndMtime` to `net.hpp` as suggest in RR-39595.
Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785
Repository: mesos
Description
-------
[stout]: Added function to simultaneously query size and mtime of URI.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
Diff: https://reviews.apache.org/r/39594/diff/
Testing
-------
make check
Thanks,
Benjamin Bannier
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141>
> >
> > Why not use `nullptr` instead?
>
> Jan Schlicht wrote:
> Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not there yet. Also there's no mention of it in the C++ style guide.
I would have commented that since this file completely relies on `NULL` instead of `nullptr` already consistence would suggest to stick to `NULL`.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
-----------------------------------------------------------
On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 7:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Till Toenshoff <to...@me.com>.
> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141>
> >
> > Why not use `nullptr` instead?
>
> Jan Schlicht wrote:
> Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not there yet. Also there's no mention of it in the C++ style guide.
>
> Benjamin Bannier wrote:
> I would have commented that since this file completely relies on `NULL` instead of `nullptr` already consistence would suggest to stick to `NULL`.
I would interpret MESOS-3243 as a transition ticket for old, existing code and not for new code.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
-----------------------------------------------------------
On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 7:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Nov. 9, 2015, 2:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141>
> >
> > Why not use `nullptr` instead?
Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not there yet. Also there's no mention of it in the C++ style guide.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
-----------------------------------------------------------
On Nov. 6, 2015, 8:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 8:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 130
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line130>
> >
> > Add blank line here please.
I would be happy to oblige, but that wouldn't commit due cpplint,
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141>
> >
> > Why not use `nullptr` instead?
>
> Jan Schlicht wrote:
> Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not there yet. Also there's no mention of it in the C++ style guide.
>
> Benjamin Bannier wrote:
> I would have commented that since this file completely relies on `NULL` instead of `nullptr` already consistence would suggest to stick to `NULL`.
>
> Till Toenshoff wrote:
> I would interpret MESOS-3243 as a transition ticket for old, existing code and not for new code.
No problem, I `nullptr`ized that instance, but left the others for the automatic cleanup.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
-----------------------------------------------------------
On Nov. 10, 2015, 1:45 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 1:45 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
-----------------------------------------------------------
As discussed, let's re-iterate on the actual function / signature.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 130)
<https://reviews.apache.org/r/39594/#comment164103>
Add blank line here please.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (lines 131 - 135)
<https://reviews.apache.org/r/39594/#comment164104>
According to our doxygen-styleguide, we are using C comments;
```
/**
*
*
*/
```
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 141)
<https://reviews.apache.org/r/39594/#comment164107>
Why not use `nullptr` instead?
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 142)
<https://reviews.apache.org/r/39594/#comment164105>
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 154)
<https://reviews.apache.org/r/39594/#comment164108>
s/0/CURLE_OK/
- Till Toenshoff
On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 7:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Extended os::stat::mtime to
optionally follow links.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 12:16 p.m.)
Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
Changes
-------
Removed `fs::mtime` and instead generalized `os::stat::mtime`.
Also renaming of various URL-related identifiers.
Summary (updated)
-----------------
[stout]: Extended os::stat::mtime to optionally follow links.
Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785
Repository: mesos
Description (updated)
-------
[stout]: Extended os::stat::mtime to optionally follow links.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp 6b1f7ad70a9cac9352463006c514e637f68e66ad
Diff: https://reviews.apache.org/r/39594/diff/
Testing (updated)
-------
make check
NOTE TO THE COMMITTER:
This should be committed together with RR-40288 (first this, then that one) to not change semantics.
Thanks,
Benjamin Bannier
Re: Review Request 39594: [stout]: Extended os::stat::mtime to
optionally follow links.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Nov. 12, 2015, 1:16 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 130
> > <https://reviews.apache.org/r/39594/diff/5/?file=1121773#file1121773line130>
> >
> > Strictly speaking, "file" is pushing assumptions into this. modificationTime? mTime? mtime?
Since I `s/fileSize/contentLength/g` I also went for `s/fileTime/contentLength/g` to match the HTTP headers.
> On Nov. 12, 2015, 1:16 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 88
> > <https://reviews.apache.org/r/39594/diff/5/?file=1121773#file1121773line88>
> >
> > Since we are only dealing with URLs here, not general URIs, how about "URLInfo"?
I definitely like the more compact name!
Since this struct isn't really specific to URLs I think making the name not URL-specific as well would make sense; this patch chain e.g. uses it in mesos to capture info on various kinds of URI. How about `URIInfo`?
> On Nov. 12, 2015, 1:16 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 89
> > <https://reviews.apache.org/r/39594/diff/5/?file=1121773#file1121773line89>
> >
> > Since the name of the header field that feeds into this field is content-length, we should probably use a name like that here. How about "contentLength"?
Cf. comment Re:`struct URIInformation`.
> On Nov. 12, 2015, 1:16 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 45
> > <https://reviews.apache.org/r/39594/diff/5/?file=1121772#file1121772line45>
> >
> > This already exists in "stat.hpp", but that version uses lstat() and we really want stat(). See size() in "stat.hpp"! Let's make a version of mtime that looks like this!
> >
> > There is only one other callsite of mtime() so far and we should find out whether following symlinks is appropriate there. To be backwards-compatible, we should not.
Good catch, `fs::mtime` does not make much sense as written.
How about synchronizing the signatures and default args of `os::stat::size` and `os::stat::mtime` so that users can decide what they wanted?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review106236
-----------------------------------------------------------
On Nov. 13, 2015, 12:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 12:16 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Extended os::stat::mtime to optionally follow links.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/stat.hpp 6b1f7ad70a9cac9352463006c514e637f68e66ad
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> NOTE TO THE COMMITTER:
>
> This should be committed together with RR-40288 (first this, then that one) to not change semantics.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review106236
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp (line 45)
<https://reviews.apache.org/r/39594/#comment164973>
This already exists in "stat.hpp", but that version uses lstat() and we really want stat(). See size() in "stat.hpp"! Let's make a version of mtime that looks like this!
There is only one other callsite of mtime() so far and we should find out whether following symlinks is appropriate there. To be backwards-compatible, we should not.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 88)
<https://reviews.apache.org/r/39594/#comment164976>
Since we are only dealing with URLs here, not general URIs, how about "URLInfo"?
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 89)
<https://reviews.apache.org/r/39594/#comment164981>
Since the name of the header field that feeds into this field is content-length, we should probably use a name like that here. How about "contentLength"?
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 99)
<https://reviews.apache.org/r/39594/#comment164974>
Naming suggestion: fetchURLInfo()
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 124)
<https://reviews.apache.org/r/39594/#comment164985>
s/fileSize/contentLength
Let's interprete what this header field actually means to us further downstream.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 130)
<https://reviews.apache.org/r/39594/#comment164987>
Strictly speaking, "file" is pushing assumptions into this. modificationTime? mTime? mtime?
- Bernd Mathiske
On Nov. 10, 2015, 6:07 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 6:07 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 2:07 p.m.)
Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
Changes
-------
Improved "jaggedness".
Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785
Repository: mesos
Description
-------
[stout]: Added function to simultaneously query size and mtime of URI.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
Diff: https://reviews.apache.org/r/39594/diff/
Testing
-------
make check
Thanks,
Benjamin Bannier
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105859
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 132)
<https://reviews.apache.org/r/39594/#comment164543>
Please add a newline after `=` as you did in l125.
- Jan Schlicht
On Nov. 10, 2015, 2:45 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 2:45 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
>
>
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [stout]: Added function to simultaneously query size and mtime of URI.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
>
> Diff: https://reviews.apache.org/r/39594/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 1:45 p.m.)
Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
Changes
-------
Incorporated review comments.
* remove unused function `contentLength`,
* fix doxygen comment style,
* use `nullptr` instead of `NULL` in new code, and
* use symbol `CURLE_OK` instead of literal `0`.
Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785
Repository: mesos
Description
-------
[stout]: Added function to simultaneously query size and mtime of URI.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
Diff: https://reviews.apache.org/r/39594/diff/
Testing
-------
make check
Thanks,
Benjamin Bannier
Re: Review Request 39594: [stout]: Added function to simultaneously
query size and mtime of URI.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/
-----------------------------------------------------------
(Updated Nov. 6, 2015, 7:52 p.m.)
Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
Changes
-------
Do not `move` to improve readbility.
Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785
Repository: mesos
Description
-------
[stout]: Added function to simultaneously query size and mtime of URI.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 311b00b41398a9fd7374f3847190468ba59c1dc9
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b
Diff: https://reviews.apache.org/r/39594/diff/
Testing
-------
make check
Thanks,
Benjamin Bannier