You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jrmccluskey (via GitHub)" <gi...@apache.org> on 2026/05/07 18:27:38 UTC

Re: [PR] Migrate to Google Cloud Dataflow Client [beam]

jrmccluskey commented on code in PR #37639:
URL: https://github.com/apache/beam/pull/37639#discussion_r3203824036


##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -1248,84 +1226,56 @@ def _verify_interpreter_version_is_supported(pipeline_options):
 # is used.
 structured_counter_translations = {
     cy_combiners.CountCombineFn: (
-        dataflow.CounterMetadata.KindValueValuesEnum.SUM,
-        MetricUpdateTranslators.translate_scalar_counter_int),
+        'Sum', MetricUpdateTranslators.translate_scalar_counter_int),

Review Comment:
   This is interesting, there's a corresponding type in the v1b3 spec (https://docs.cloud.google.com/workflows/docs/reference/googleapis/dataflow/v1b3/Overview#countermetadata) but there's not an equivalent in the python library. Probably another improvement we should make to the client



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org