You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/24 03:49:01 UTC
[GitHub] [dubbo-go-pixiu] cityiron opened a new issue, #457: server_handler.go OnMessage pkg is change false
cityiron opened a new issue, #457:
URL: https://github.com/apache/dubbo-go-pixiu/issues/457
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
-->
**What happened**:
When run dubbo2http samples use develop branch, will hit error log like follow code:
```go
decodeResult, drOK := pkg.(remoting.DecodeResult)
if !drOK {
logger.Errorf("illegal package{%#v}", pkg)
return
}
```
this pkg object is `*remoting.DecodeResult`
**What you expected to happen**:
drOk will true, and run continue.
**How to reproduce it (as minimally and precisely as possible)**:
Just run pixiu, samples/dubbohttpproxy/server/http/server.go, and run dubbo2http_test.go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] complone commented on issue #457: server_handler.go OnMessage pkg is judge false
Posted by GitBox <gi...@apache.org>.
complone commented on issue #457:
URL: https://github.com/apache/dubbo-go-pixiu/issues/457#issuecomment-1193912778
i want to try to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] cityiron commented on issue #457: server_handler.go OnMessage pkg is judge false
Posted by GitBox <gi...@apache.org>.
cityiron commented on issue #457:
URL: https://github.com/apache/dubbo-go-pixiu/issues/457#issuecomment-1193241065
Just change to
```go
decodeResult, drOK := pkg.(*remoting.DecodeResult)
if !drOK {
logger.Errorf("illegal package{%#v}", pkg)
return
}
```
, run success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] complone commented on issue #457: server_handler.go OnMessage pkg is judge false
Posted by GitBox <gi...@apache.org>.
complone commented on issue #457:
URL: https://github.com/apache/dubbo-go-pixiu/issues/457#issuecomment-1195101695
I have reproduced the problem according to the steps you gave, and found that the current version does not perform heartbeat detection on the session, which is fixed in dubbo-go@v3. The code snippet is:
```
decodeResult, drOK := pkg.(*remoting.DecodeResult)
if !drOK || decodeResult == ((*remoting.DecodeResult)(nil)) {
logger.Errorf("illegal package{%#v}", pkg)
return
}
if !decodeResult.IsRequest {
res := decodeResult.Result.(*remoting.Response)
if res.Event {
logger.Debugf("get rpc heartbeat response{%#v}", res)
if res.Error != nil {
logger.Errorf("rpc heartbeat response{error: %#v}", res.Error)
}
res.Handle()
return
}
logger.Errorf("illegal package but not heartbeat. {%#v}", pkg)
return
}
req := decodeResult.Result.(*remoting.Request)
```
see code: https://github.com/apache/dubbo-go/blob/1e82194facaf976c29c14ac92df94deacc89ff1c/remoting/getty/listener.go#L95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks closed issue #457: server_handler.go OnMessage pkg is judge false
Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #457: server_handler.go OnMessage pkg is judge false
URL: https://github.com/apache/dubbo-go-pixiu/issues/457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] complone commented on issue #457: server_handler.go OnMessage pkg is judge false
Posted by GitBox <gi...@apache.org>.
complone commented on issue #457:
URL: https://github.com/apache/dubbo-go-pixiu/issues/457#issuecomment-1195102192
Maybe you need to update the version of dubbo-go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] complone commented on issue #457: server_handler.go OnMessage pkg is judge false
Posted by GitBox <gi...@apache.org>.
complone commented on issue #457:
URL: https://github.com/apache/dubbo-go-pixiu/issues/457#issuecomment-1194027746
i want to try to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org