You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/16 15:16:16 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2481: da1469x disable dcdc when vbus is present
kasjer opened a new pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481
DCDC is more efficient then LDO to provide power rails but in case
when VBUS (charger) is present, it is actually more efficient from
battery point of view to disable DCDC (which is powered by battery)
and use LDO that is powered by VBUS.
This way charging current will go to battery and not to DCDC reducing charge time.
It will also prevent discharging battery when it was fully changed and not removed
from charger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481#issuecomment-779904663
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on a change in pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
kasjer commented on a change in pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481#discussion_r577369085
##########
File path: hw/mcu/dialog/da1469x/src/da1469x_prail.c
##########
@@ -24,6 +24,9 @@
#include "mcu/da1469x_hal.h"
#include "mcu/da1469x_prail.h"
#include "mcu/da1469x_retreg.h"
+#if MYNEWT_VAL(ENABLE_BLE)
Review comment:
done
##########
File path: hw/mcu/dialog/da1469x/src/da1469x_prail.c
##########
@@ -176,13 +179,21 @@ da1469x_prail_dcdc_restore(void)
if (CRG_TOP->ANA_STATUS_REG & CRG_TOP_ANA_STATUS_REG_COMP_VBAT_HIGH_Msk) {
da1469x_retreg_restore(g_mcu_dcdc_config, ARRAY_SIZE(g_mcu_dcdc_config));
DCDC->DCDC_CTRL1_REG |= DCDC_DCDC_CTRL1_REG_DCDC_ENABLE_Msk;
+#if MYNEWT_VAL(ENABLE_BLE)
+ /* Enable turnning DCDC on from CMAC core. */
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481#issuecomment-780353083
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer commented on a change in pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
kasjer commented on a change in pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481#discussion_r577369201
##########
File path: hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c
##########
@@ -27,6 +27,8 @@
#include <bsp/bsp.h>
#if MYNEWT_VAL(DA1469X_CHARGER_USE_CHARGE_CONTROL)
#include <charge-control/charge_control.h>
+#include <mcu/da1469x_prail.h>
+
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481#issuecomment-779904663
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on a change in pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on a change in pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481#discussion_r576908281
##########
File path: hw/mcu/dialog/da1469x/src/da1469x_prail.c
##########
@@ -176,13 +179,21 @@ da1469x_prail_dcdc_restore(void)
if (CRG_TOP->ANA_STATUS_REG & CRG_TOP_ANA_STATUS_REG_COMP_VBAT_HIGH_Msk) {
da1469x_retreg_restore(g_mcu_dcdc_config, ARRAY_SIZE(g_mcu_dcdc_config));
DCDC->DCDC_CTRL1_REG |= DCDC_DCDC_CTRL1_REG_DCDC_ENABLE_Msk;
+#if MYNEWT_VAL(ENABLE_BLE)
+ /* Enable turnning DCDC on from CMAC core. */
Review comment:
typo
##########
File path: hw/drivers/chg_ctrl/da1469x_charger/src/da1469x_charger.c
##########
@@ -27,6 +27,8 @@
#include <bsp/bsp.h>
#if MYNEWT_VAL(DA1469X_CHARGER_USE_CHARGE_CONTROL)
#include <charge-control/charge_control.h>
+#include <mcu/da1469x_prail.h>
+
Review comment:
empty line
##########
File path: hw/mcu/dialog/da1469x/src/da1469x_prail.c
##########
@@ -176,13 +179,21 @@ da1469x_prail_dcdc_restore(void)
if (CRG_TOP->ANA_STATUS_REG & CRG_TOP_ANA_STATUS_REG_COMP_VBAT_HIGH_Msk) {
da1469x_retreg_restore(g_mcu_dcdc_config, ARRAY_SIZE(g_mcu_dcdc_config));
DCDC->DCDC_CTRL1_REG |= DCDC_DCDC_CTRL1_REG_DCDC_ENABLE_Msk;
+#if MYNEWT_VAL(ENABLE_BLE)
+ /* Enable turnning DCDC on from CMAC core. */
+ g_cmac_shared_data->dcdc.enabled = 1;
+#endif
}
}
#endif
void
da1469x_prail_dcdc_disable(void)
{
+#if MYNEWT_VAL(ENABLE_BLE)
+ /* Prevent CMAC from turnning DCDC on. */
Review comment:
typo
##########
File path: hw/mcu/dialog/da1469x/src/da1469x_prail.c
##########
@@ -24,6 +24,9 @@
#include "mcu/da1469x_hal.h"
#include "mcu/da1469x_prail.h"
#include "mcu/da1469x_retreg.h"
+#if MYNEWT_VAL(ENABLE_BLE)
Review comment:
there's no such setting, use `MYNEWT_VAL_CHOICE(BLE_HCI_TRANSPORT, dialog_cmac)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2481: da1469x disable dcdc when vbus is present
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2481:
URL: https://github.com/apache/mynewt-core/pull/2481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org