You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/11/21 11:34:09 UTC
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84
CB-8156 Call error callback on pickContact cancellation
Also introduce OPERATION_CANCELLED_ERROR as an error code for reporting contact picker cancellation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-8156
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit d49a9148a23a672dd9ed7e246c48227f9b5653f0
Author: Vladimir Kotikov <ko...@gmail.com>
Date: 2015-11-21T09:50:11Z
CB-8156 Call error callback on pickContact cancellation
Also introduce OPERATION_CANCELLED_ERROR as an error code for reporting contact picker cancellation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637931
--- Diff: src/windows/ContactProxy.js ---
@@ -242,7 +242,9 @@ module.exports = {
pickRequest.done(function (contact) {
// if contact was not picked
if (!contact) {
- fail && fail(new Error("User did not pick a contact."));
--- End diff --
This looks good. The implied check for `fail != null` here was unnecessary as ALL calls to exec proxies have valid success/error function passed in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159017060
One more thing ...
Please add a test for the new constant to
`contacts.spec.25 ContactError constants should be defined` at /tests/tests.js#L473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637648
--- Diff: src/android/ContactManager.java ---
@@ -52,6 +52,7 @@ Licensed to the Apache Software Foundation (ASF) under one
public static final int PENDING_OPERATION_ERROR = 3;
public static final int IO_ERROR = 4;
public static final int NOT_SUPPORTED_ERROR = 5;
+ public static final int OPERATION_CANCELLED_ERROR = 5;
--- End diff --
Isn't this supposed to be 6 as above, so below?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159188305
Updated. Thanks for reviewing, @purplecabbage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159016399
Looks good, except for the java implementation (re)used error code 5 instead of the 6 used everywhere else. The added tests should reveal this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org