[GitHub] [skywalking] sonatype-lift[bot] commented on a diff in pull request #9508: Fix JDBC TTL to delete additional tables data.

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on code in PR #9508:
URL: https://github.com/apache/skywalking/pull/9508#discussion_r952217049


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/segment/SegmentRecord.java:
##########
@@ -95,6 +95,14 @@ public class SegmentRecord extends Record {
     @Column(columnName = TAGS, indexOnly = true)
     @SQLDatabase.AdditionalEntity(additionalTables = {ADDITIONAL_TAG_TABLE})
     private List<String> tags;
+    /**
+     * The additional tables need timeBucket for TTL.
+     */
+    @Getter
+    @Setter

Review Comment:
   💬 4 similar findings have been found in this PR
   
   ---
   
   *[MissingOverride](https://errorprone.info/bugpattern/MissingOverride):*  setTimeBucket overrides method in Record; expected @Override
   
   ---
   
   
   ```suggestion
       @Override @Setter
   ```
   
   
   
   ---
   
   <details><summary><b>Expand here to view all instances of this finding</b></summary><br/>
   
   <div align="center">
   
   | **File Path** | **Line Number** |
   | ------------- | ------------- |
   | oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/HistogramFunction.java | [51](https://github.com/wankai123/skywalking/blob/9438b02e8f920225ba693b85db9c62ee8e40e1c8/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/meter/function/HistogramFunction.java#L51)|
   | oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/segment/SegmentRecord.java | [101](https://github.com/wankai123/skywalking/blob/9438b02e8f920225ba693b85db9c62ee8e40e1c8/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/segment/SegmentRecord.java#L101)|
   | oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/MinLongMetrics.java | [33](https://github.com/wankai123/skywalking/blob/9438b02e8f920225ba693b85db9c62ee8e40e1c8/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/MinLongMetrics.java#L33)|
   | oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/EntityDescription/InstanceEntityDescription.java | [36](https://github.com/wankai123/skywalking/blob/9438b02e8f920225ba693b85db9c62ee8e40e1c8/oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/EntityDescription/InstanceEntityDescription.java#L36)|
   <p><a href="https://lift.sonatype.com/results/github.com/apache/skywalking/01GB4MVSGFF6YKWRRP1AR3EK9C?t=ErrorProne|MissingOverride" target="_blank">Visit the Lift Web Console</a> to find more details in your report.</p></div></details>
   
   
   
   ---
   
   Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
   Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR.
   Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
   
   When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands.
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=320351152&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=320351152&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=320351152&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=320351152&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=320351152&lift_comment_rating=5) ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org