You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2021/08/07 19:23:40 UTC

[groovy] 02/03: Trivial refactoring: extract constant

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit 90bea6cf28710d5b66a0725c83d4fa2f1f68ef2d
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sun Aug 8 03:21:02 2021 +0800

    Trivial refactoring: extract constant
---
 src/main/java/org/codehaus/groovy/ast/ClassNode.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/codehaus/groovy/ast/ClassNode.java b/src/main/java/org/codehaus/groovy/ast/ClassNode.java
index c938762..8e22643 100644
--- a/src/main/java/org/codehaus/groovy/ast/ClassNode.java
+++ b/src/main/java/org/codehaus/groovy/ast/ClassNode.java
@@ -121,6 +121,7 @@ import static org.objectweb.asm.Opcodes.ACC_SYNTHETIC;
  * @see org.codehaus.groovy.ast.ClassHelper
  */
 public class ClassNode extends AnnotatedNode {
+    private static final String CLINIT = "<clinit>";
 
     private static class MapOfLists {
         Map<Object, List<MethodNode>> map;
@@ -804,9 +805,9 @@ public class ClassNode extends AnnotatedNode {
 
     private MethodNode getOrAddStaticConstructorNode() {
         MethodNode method;
-        List<MethodNode> declaredMethods = getDeclaredMethods("<clinit>");
+        List<MethodNode> declaredMethods = getDeclaredMethods(CLINIT);
         if (declaredMethods.isEmpty()) {
-            method = addMethod("<clinit>", ACC_STATIC, ClassHelper.VOID_TYPE, Parameter.EMPTY_ARRAY, ClassNode.EMPTY_ARRAY, new BlockStatement());
+            method = addMethod(CLINIT, ACC_STATIC, ClassHelper.VOID_TYPE, Parameter.EMPTY_ARRAY, ClassNode.EMPTY_ARRAY, new BlockStatement());
             method.setSynthetic(true);
         } else {
             method = declaredMethods.get(0);