[jira] [Commented] (SENTRY-777) SentryServiceIntegrationBase#after() should be run under client subject

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597598#comment-14597598 ] 

Hadoop QA commented on SENTRY-777:
----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12741267/SENTRY-777.003.patch against master.

{color:red}Overall:{color} -1 due to 2 errors

{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed: org.apache.sentry.provider.db.service.thrift.TestSentryServiceClientPool

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/652/console

This message is automatically generated.

> SentryServiceIntegrationBase#after() should be run under client subject
> -----------------------------------------------------------------------
>
>                 Key: SENTRY-777
>                 URL: https://issues.apache.org/jira/browse/SENTRY-777
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>             Fix For: 1.6.0
>
>         Attachments: SENTRY-777.001.patch, SENTRY-777.002.patch, SENTRY-777.003.patch
>
>
> {noformat}
>   @After
>   public void after() throws Exception {
>         if (client != null) {
>           Set<TSentryRole> tRoles = client.listRoles(ADMIN_USER);
>           if (tRoles != null) {
>             for (TSentryRole tRole : tRoles) {
>               client.dropRole(ADMIN_USER, tRole.getRoleName());
>             }
>           }
>           client.close();
>         }
>         policyFilePath.delete();
>   }
> {noformat}
> * client in {{after()}} isn't run under client subject, if client need client subject, such as in Kerberos mode, it may throw an exception.
> * {{policyFilePath.delete();}} may not execute if the client throws an exception when it does operations like clean db or close, there should be a try-catch-finally statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)