You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2007/09/08 19:21:41 UTC

Re: [PATCH] For consistency mark some dates and strings for localization (Was: Improve consistency of that which dates are marked for localization)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arfrever Frehtes Taifersar Arahesis wrote:
> Hello,
> 
> I'm attaching a new patch. I hope that it won't be forgotten.

I haven't looked at the patch, but future patches will be more
noticeable if you include the [PATCH] heading in the subject line, as
recommended by HACKING: http://subversion.tigris.org/hacking.html#patches

I've added it to the subject of this mail for you.

Thanks,
- -Hyrum

> [[[
> Mark some dates and strings for localization.
> 
> * subversion/libsvn_diff/diff_file.c
>   (output_unified_default_hdr): Mark a date for localization.
> * subversion/svn/list-cmd.c
>   (print_dirent): Mark dates for localization.
> * subversion/svnlook/main.c
>   (generate_label): Mark strings for localization.
>   "txn" and "rev" are translatable here.
> 
> Patch by: Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>
> ]]]
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: subversion/libsvn_diff/diff_file.c
> ===================================================================
> --- subversion/libsvn_diff/diff_file.c	(revision 26497)
> +++ subversion/libsvn_diff/diff_file.c	(working copy)
> @@ -1058,7 +1058,7 @@
>    apr_time_exp_lt(&exploded_time, file_info.mtime);
>  
>    apr_strftime(time_buffer, &time_len, sizeof(time_buffer) - 1,
> -               "%a %b %e %H:%M:%S %Y", &exploded_time);
> +               _("%a %b %e %H:%M:%S %Y"), &exploded_time);
>  
>    *header = apr_psprintf(pool, "%s\t%s", path, time_buffer);
>  
> Index: subversion/svn/list-cmd.c
> ===================================================================
> --- subversion/svn/list-cmd.c	(revision 26497)
> +++ subversion/svn/list-cmd.c	(working copy)
> @@ -87,12 +87,12 @@
>            && apr_time_sec(dirent->time - now) < (365 * 86400 / 2))
>          {
>            apr_err = apr_strftime(timestr, &size, sizeof(timestr),
> -                                 "%b %d %H:%M", &exp_time);
> +                                 _("%b %d %H:%M"), &exp_time);
>          }
>        else
>          {
>            apr_err = apr_strftime(timestr, &size, sizeof(timestr),
> -                                 "%b %d  %Y", &exp_time);
> +                                 _("%b %d  %Y"), &exp_time);
>          }
>  
>        /* if that failed, just zero out the string and print nothing */
> Index: subversion/svnlook/main.c
> ===================================================================
> --- subversion/svnlook/main.c	(revision 26497)
> +++ subversion/svnlook/main.c	(working copy)
> @@ -700,10 +700,10 @@
>      datestr = "                       ";
>  
>    if (name)
> -    *label = apr_psprintf(pool, "%s\t%s (txn %s)",
> +    *label = apr_psprintf(pool, _("%s\t%s (txn %s)"),
>                            path, datestr, name);
>    else
> -    *label = apr_psprintf(pool, "%s\t%s (rev %ld)",
> +    *label = apr_psprintf(pool, _("%s\t%s (rev %ld)"),
>                            path, datestr, rev);
>    return SVN_NO_ERROR;
>  }

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG4vYzCwOubk4kUXwRAuhLAKDrMoQSCThW5D/QtJMG2sg89raVSQCfbf5e
mQCHZcvF+IpNdNTXE5sCBVY=
=l97O
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] For consistency mark some dates and strings for localization (Was: Improve consistency of that which dates are marked for localization)

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

2007-09-08 21:21:18 Hyrum K. Wright napisaƂ(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > Hello,
> >
> > I'm attaching a new patch. I hope that it won't be forgotten.
> 
> I haven't looked at the patch, but future patches will be more
> noticeable if you include the [PATCH] heading in the subject line, as
> recommended by HACKING: http://subversion.tigris.org/hacking.html#patches
> 
> I've added it to the subject of this mail for you.

Sorry, I accidentally forgot about it :( .

- -- 
Arfrever Frehtes Taifersar Arahesis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.6 (GNU/Linux)

iD8DBQFG4vdT/axNJ4Xo/ZERAtjxAJ0dmdQYXf236ziASjqjA/OOK5/NXwCgluy1
WWR12XFQUhB7G2iXolfG6eY=
=0CfJ
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org