You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/08/17 10:02:45 UTC
[GitHub] [datasketches-cpp] why520it opened a new pull request, #299: Update reverse_purge_hash_map copy constructor
why520it opened a new pull request, #299:
URL: https://github.com/apache/datasketches-cpp/pull/299
I think reverse_purge_hash_map copy constructor should do this here, the original result is not being able to copy all the values. Or remove the if and copy all the values directly, but it may affect some performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov merged pull request #299: Update reverse_purge_hash_map copy constructor
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov merged PR #299:
URL: https://github.com/apache/datasketches-cpp/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on pull request #299: Update reverse_purge_hash_map copy constructor
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on PR #299:
URL: https://github.com/apache/datasketches-cpp/pull/299#issuecomment-1219983516
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] why520it commented on pull request #299: Update reverse_purge_hash_map copy constructor
Posted by GitBox <gi...@apache.org>.
why520it commented on PR #299:
URL: https://github.com/apache/datasketches-cpp/pull/299#issuecomment-1217799770
I think reverse_purge_hash_map copy constructor should do this here, the original result is not being able to copy all the values. Or remove the if and copy all the values directly, but it may affect some performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #299: Update reverse_purge_hash_map copy constructor
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #299:
URL: https://github.com/apache/datasketches-cpp/pull/299#issuecomment-1219970864
## Pull Request Test Coverage Report for [Build 2874466714](https://coveralls.io/builds/51778604)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **92.347%**
---
| Totals | [](https://coveralls.io/builds/51778604) |
| :-- | --: |
| Change from base [Build 2866442392](https://coveralls.io/builds/51688515): | 0.0% |
| Covered Lines: | 2196 |
| Relevant Lines: | 2378 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org