[GitHub] [bookkeeper] codelipenghui commented on a diff in pull request #3842: Make read entry request recyclable

["codelipenghui (via GitHub)" <gi...@apache.org>]

codelipenghui commented on code in PR #3842:
URL: https://github.com/apache/bookkeeper/pull/3842#discussion_r1127866317


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -122,6 +122,7 @@ protected void processPacket() {
         if (LOG.isTraceEnabled()) {
             LOG.trace("Read entry rc = {} for {}", errorCode, request);
         }
+        request.recycle();

Review Comment:
   Yes, we can only recycle the request here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org