You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/13 19:02:56 UTC
[GitHub] [fineract] vorburger opened a new pull request #765: improve
ClientSavingsIntegrationTest error reporting (FINERACT-852)
vorburger opened a new pull request #765: improve ClientSavingsIntegrationTest error reporting (FINERACT-852)
URL: https://github.com/apache/fineract/pull/765
Adds a new assertion for a hopefully clearer failure message than the
confusing low-level technical ArrayIndexOutOfBoundsException we
regularly hit on Travis CI.
Similar to https://github.com/apache/fineract/pull/764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum merged pull request #765: improve
ClientSavingsIntegrationTest error reporting (FINERACT-852)
Posted by GitBox <gi...@apache.org>.
awasum merged pull request #765: improve ClientSavingsIntegrationTest error reporting (FINERACT-852)
URL: https://github.com/apache/fineract/pull/765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #765: improve
ClientSavingsIntegrationTest error reporting (FINERACT-852)
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #765: improve ClientSavingsIntegrationTest error reporting (FINERACT-852)
URL: https://github.com/apache/fineract/pull/765#issuecomment-613892600
@awasum how would you feel about already merging this one? Despite the failing build, which is what #764 would avoid... this change, contrary to #761 does NOT actually comment (deactivate) out either of those two test failing tests, but just attempts to make the error reporting from one of those test failures more clear, for future investigations.
If LGTY would you be wiling to merge it even with the IT build failure? Risk seems minimal, to me.
@thesmallstar @fynmanoj FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services