[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9499: Add query interruption flag check to broker groupby reduction

[GitBox <gi...@apache.org>]

vvivekiyer commented on code in PR #9499:
URL: https://github.com/apache/pinot/pull/9499#discussion_r984088368


##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java:
##########
@@ -289,6 +291,9 @@ public void runJob() {
 
               int numRows = dataTable.getNumberOfRows();
               for (int rowId = 0; rowId < numRows; rowId++) {
+                if (rowId % MAX_ROWS_UPSERT_PER_INTERRUPTION_CHECK == 0 && Thread.interrupted()) {
+                  throw new EarlyTerminationException();

Review Comment:
   Question: Is it not enough to just `return` here? Given that the main thread already threw a timeout exception? It also keeps the behavior consistent with how we return for interrupts at L279.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org