You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/15 01:52:30 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #3059: Remove CONFIG_BCH
yamt opened a new pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059
## Summary
drivers/bch/Kconfig: Remove the separete CONFIG_BCH config
"CONFIG_BCH is not set" is confusing as the bch driver itself
is always there unless CONFIG_DISABLE_MOUNTPOINT=y.
## Impact
## Testing
locally build-tested a few combinations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #3059: Remove CONFIG_BCH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3059: Remove CONFIG_BCH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059#discussion_r594025322
##########
File path: drivers/bch/Kconfig
##########
@@ -3,16 +3,18 @@
# see the file kconfig-language.txt in the NuttX tools repository.
#
-menuconfig BCH
- bool "Block-to-Character (BCH) Support"
- default n
- ---help---
- Contains logic that may be used to convert a block driver into
- a character driver. This is the complementary conversion as that
- performed by loop.c. See include/nuttx/drivers/drivers.h for
- registration information.
+# Block-to-Character (BCH) Support
+#
+# BCH contains logic that may be used to convert a block driver into
+# a character driver. This is the complementary conversion as that
+# performed by loop.c. See include/nuttx/drivers/drivers.h for
+# registration information.
+#
+# The BCH support itself is enabled unless CONFIG_DISABLE_MOUNTPOINT
Review comment:
How to enable mountpoint without BCH? BCH just waste the flash if user never open the block device directly, but access the block device indirectly through file system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3059: Remove CONFIG_BCH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059#discussion_r594025322
##########
File path: drivers/bch/Kconfig
##########
@@ -3,16 +3,18 @@
# see the file kconfig-language.txt in the NuttX tools repository.
#
-menuconfig BCH
- bool "Block-to-Character (BCH) Support"
- default n
- ---help---
- Contains logic that may be used to convert a block driver into
- a character driver. This is the complementary conversion as that
- performed by loop.c. See include/nuttx/drivers/drivers.h for
- registration information.
+# Block-to-Character (BCH) Support
+#
+# BCH contains logic that may be used to convert a block driver into
+# a character driver. This is the complementary conversion as that
+# performed by loop.c. See include/nuttx/drivers/drivers.h for
+# registration information.
+#
+# The BCH support itself is enabled unless CONFIG_DISABLE_MOUNTPOINT
Review comment:
How to enable mountpoint without BCH? BCH just waste the flash if user never open the block device directly, but access the block device indirectly through file system. So, should we correct Makefile and code to reference BCH only when CONFIG_BCH=y instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3059: Remove CONFIG_BCH
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059#discussion_r594046316
##########
File path: drivers/bch/Kconfig
##########
@@ -3,16 +3,18 @@
# see the file kconfig-language.txt in the NuttX tools repository.
#
-menuconfig BCH
- bool "Block-to-Character (BCH) Support"
- default n
- ---help---
- Contains logic that may be used to convert a block driver into
- a character driver. This is the complementary conversion as that
- performed by loop.c. See include/nuttx/drivers/drivers.h for
- registration information.
+# Block-to-Character (BCH) Support
+#
+# BCH contains logic that may be used to convert a block driver into
+# a character driver. This is the complementary conversion as that
+# performed by loop.c. See include/nuttx/drivers/drivers.h for
+# registration information.
+#
+# The BCH support itself is enabled unless CONFIG_DISABLE_MOUNTPOINT
Review comment:
ok. it makes sense. let me think about it a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3059: Remove CONFIG_BCH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059#issuecomment-801088924
@yamt can we close this PR now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3059: Remove CONFIG_BCH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3059:
URL: https://github.com/apache/incubator-nuttx/pull/3059#issuecomment-801088924
@yamt can we close this PR now after https://github.com/apache/incubator-nuttx/pull/3061 get merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org