[jira] [Commented] (FLINK-19901) Unable to exclude metrics variables for the last metrics reporter.

["Truong Duc Kien (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-19901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223565#comment-17223565 ] 

Truong Duc Kien commented on FLINK-19901:
-----------------------------------------

[~chesnay] Can you take look ? Thanks.

> Unable to exclude metrics variables for the last metrics reporter.
> ------------------------------------------------------------------
>
>                 Key: FLINK-19901
>                 URL: https://issues.apache.org/jira/browse/FLINK-19901
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Metrics
>    Affects Versions: 1.11.2
>            Reporter: Truong Duc Kien
>            Priority: Major
>
> We discovered a bug that leads to the setting {{scope.variables.excludes}} being ignored for the very last metric reporter.
> Because {{reporterIndex}} was incremented before the length check, the last metrics reporter setting is overflowed back to 0.
> Interestingly, this bug does not trigger when there's only one metric reporter, because slot 0 is actually overwritten with that reporter's variables instead of being used to store all variables in that case.
> {code:java}
> public abstract class AbstractMetricGroup<A extends AbstractMetricGroup<?>> implements MetricGroup {
> ...
> 	public Map<String, String> getAllVariables(int reporterIndex, Set<String> excludedVariables) {
> 		// offset cache location to account for general cache at position 0
> 		reporterIndex += 1;
> 		if (reporterIndex < 0 || reporterIndex >= logicalScopeStrings.length) {
> 			reporterIndex = 0;
> 		}
> 		// if no variables are excluded (which is the default!) we re-use the general variables map to save space
> 		return internalGetAllVariables(excludedVariables.isEmpty() ? 0 : reporterIndex, excludedVariables);
> 	}
> ...
> {code}
>  [Github link to the above code|https://github.com/apache/flink/blob/3bf5786655c3bb914ce02ebb0e4a1863b205b829/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java#L122]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)