You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2023/01/15 19:42:18 UTC
[GitHub] [logging-log4j2] vy opened a new issue, #1207: Enforce signed commits
vy opened a new issue, #1207:
URL: https://github.com/apache/logging-log4j2/issues/1207
As [discussed in the mailing list](https://lists.apache.org/thread/9d53znkksfkw0rkmgb4pk1ws95m4y3nb), we better enforce signed commits in the repository. This better be reflected in [a GitHub Pull Request template](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository) along with some other checks:
- Changelog entry
- Signed commits
- Tests
- etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on issue #1207: Enforce signed commits
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on issue #1207:
URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1383269679
- running `spotless:apply`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on issue #1207: Enforce signed commits
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on issue #1207:
URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384455056
@vy,
`spotless:check` is part of the build. We should document `spotless:apply` there so that contributors don't have to wonder why the build failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy closed issue #1207: Enforce signed commits
Posted by GitBox <gi...@apache.org>.
vy closed issue #1207: Enforce signed commits
URL: https://github.com/apache/logging-log4j2/issues/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on issue #1207: Enforce signed commits
Posted by GitBox <gi...@apache.org>.
vy commented on issue #1207:
URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384476018
Fixed in c6019c979ac07c1e664d066d01302561b47d2c72 and b61fd7b7fb5e9036b915992d5fa5522e72e424ae.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] vy commented on issue #1207: Enforce signed commits
Posted by GitBox <gi...@apache.org>.
vy commented on issue #1207:
URL: https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384447513
> * running `spotless:apply`
Is this really necessary given it is part of the build? It sounds like _"building the sources"_ or am I exaggerating?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org