[GitHub] [nifi] mattyb149 commented on a change in pull request #5830: NIFI-4307 Add support for Kotlin to the scripting bundle

[GitBox <gi...@apache.org>]

mattyb149 commented on a change in pull request #5830:
URL: https://github.com/apache/nifi/pull/5830#discussion_r823840634



##########
File path: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/resources/META-INF/services/javax.script.ScriptEngineFactory
##########
@@ -12,4 +12,5 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-org.apache.nifi.processors.script.engine.ClojureScriptEngineFactory
\ No newline at end of file
+org.apache.nifi.processors.script.engine.ClojureScriptEngineFactory
+org.jetbrains.kotlin.script.jsr223.KotlinJsr223JvmLocalScriptEngineFactory

Review comment:
       Is this necessary for the ScriptEngineFactory to be picked up by the ServiceLoader? It causes warnings when building without the profile enabled, and I'm curious as to why the ServiceLoader wouldn't pick it up if the library was included...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org