You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sihuazhou <gi...@git.apache.org> on 2018/06/04 12:29:52 UTC

[GitHub] flink pull request #6087: [FLINK-9410] [yarn] Replace NMClient with NMClient...

Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6087#discussion_r192723013
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -356,7 +363,8 @@ public void onContainersAllocated(List<Container> containers) {
     
     					final String containerIdStr = container.getId().toString();
     					final ResourceID resourceId = new ResourceID(containerIdStr);
    -
    +					this.resourceId = resourceId;
    +					this.container = container;
    --- End diff --
    
    I think we can't do it like this, the `resourceId` will be reset by another request... as well as the `contianer`


---