[jira] [Commented] (MESOS-8288) SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect is flaky.

["Vinod Kone (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279214#comment-16279214 ] 

Vinod Kone commented on MESOS-8288:
-----------------------------------

[~bmahler] Can you look into this as its been pretty flaky? Looks like you wrote the test. The expectation on executor shutdown in the test seems wrong because we are not waiting for it to happen before exiting the test.

```
  // Now spoof an executor re-registration, it should be ignored
  // and the agent should not respond.
  EXPECT_NO_FUTURE_PROTOBUFS(ExecutorReregisteredMessage(), _, _);

  Future<Nothing> executorShutdown;
  EXPECT_CALL(exec, shutdown(_))
    .WillOnce(FutureSatisfy(&executorShutdown));

  UPID executorPid = registerExecutorMessage->from;
  UPID agentPid = registerExecutorMessage->to;

  ReregisterExecutorMessage reregisterExecutorMessage;
  reregisterExecutorMessage.mutable_executor_id()->CopyFrom(
      task.executor().executor_id());
  reregisterExecutorMessage.mutable_framework_id()->CopyFrom(
      frameworkId);

  process::post(executorPid, agentPid, reregisterExecutorMessage);

  Clock::settle();
  EXPECT_TRUE(executorShutdown.isPending());

  driver.stop();
  driver.join();
```

> SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect is flaky.
> -------------------------------------------------------------------
>
>                 Key: MESOS-8288
>                 URL: https://issues.apache.org/jira/browse/MESOS-8288
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>         Environment: CentOS 7;
> Debian 8;
> Ubuntu 16.04;
>            Reporter: Alexander Rukletsov
>              Labels: flaky-test
>         Attachments: IgnoreV0ExecutorIfItReregistersWithoutReconnect-badrun.txt
>
>
> {noformat}
> ../../src/tests/slave_tests.cpp:7888
> Actual function call count doesn't match EXPECT_CALL(exec, shutdown(_))...
>          Expected: to be called once
>            Actual: never called - unsatisfied and active
> {noformat}
> Full log attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)